Skip to content

maximum_line_length determines NOQA the hard way #538

@sigmavirus24

Description

@sigmavirus24

The Checker has a noqa attribute that is updated per-physical line. This can be requested by a check in its signature. maximum_line_length, however, runs the regular expression a second time on the line instead of relying on the Checker attribute. Regular expressions in Python aren't exactly the fastest, so repeatedly doubling the work is bad for performance.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions