Fixed danmar#6243 (False positive: uninitialized variable, looping with goto)

danmar · danmar · commit bfd8a69e74f8 · 2015-10-27T12:40:52.000+01:00
diff --git a/lib/checkuninitvar.cpp b/lib/checkuninitvar.cpp
@@ -484,6 +484,11 @@ bool CheckUninitVar::checkScopeForVariable(const Token *tok, const Variable& var
             return true;
         }
 
+        // bailout if there is a goto label
+        if (Token::Match(tok, "[;{}] %name% :")) {
+            return true;
+        }
+
         if (tok->str() == "?") {
             if (!tok->astOperand2())
                 return true;
diff --git a/test/testuninitvar.cpp b/test/testuninitvar.cpp
@@ -611,6 +611,16 @@ class TestUninitVar : public TestFixture {
                        "}", "test.cpp", false);
         ASSERT_EQUALS("", errout.str());
 
+        checkUninitVar("int foo() {\n"
+                       "    int x,y=0;\n"
+                       "again:\n"
+                       "    if (y) return x;\n"
+                       "    x = a;\n"
+                       "    y = 1;\n"
+                       "    goto again;\n"
+                       "}", "test.c", false);
+        ASSERT_EQUALS("", errout.str());
+
         // Ticket #3873 (false positive)
         checkUninitVar("MachineLoopRange *MachineLoopRanges::getLoopRange(const MachineLoop *Loop) {\n"
                        "  MachineLoopRange *&Range = Cache[Loop];\n"
