updated style messages

danmar · danmar · commit 4bde4d5a4a8f · 2015-06-01T21:22:47.000+02:00
diff --git a/lib/checktype.cpp b/lib/checktype.cpp
@@ -366,13 +366,15 @@ void CheckType::longCastAssignError(const Token *tok)
     reportError(tok,
                 Severity::style,
                 "truncLongCastAssignment",
-                "possible loss of information, int result is assigned to long variable");
+                "int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information.\n"
+                "int result is assigned to long variable. If the variable is long to avoid loss of information, then there is loss of information. To avoid loss of information you must cast a calculation operand to long, for example 'l = a * b;' => 'l = (long)a * b;'.");
 }
 
 void CheckType::longCastReturnError(const Token *tok)
 {
     reportError(tok,
                 Severity::style,
                 "truncLongCastReturn",
-                "possible loss of information, int result is returned as long value");
+                "int result is returned as long value. If the return value is long to avoid loss of information, then you have loss of information.\n"
+                "int result is returned as long value. If the return value is long to avoid loss of information, then there is loss of information. To avoid loss of information you must cast a calculation operand to long, for example 'return a*b;' => 'return (long)a*b'.");
 }
diff --git a/test/testtype.cpp b/test/testtype.cpp
@@ -146,7 +146,7 @@ class TestType : public TestFixture {
               "  const long ret = x * y;\n"
               "  return ret;\n"
               "}\n", &settings);
-        ASSERT_EQUALS("[test.cpp:2]: (style) possible loss of information, int result is assigned to long variable\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:2]: (style) int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information.\n", errout.str());
 
         // typedef
         check("long f(int x, int y) {\n"
@@ -170,7 +170,7 @@ class TestType : public TestFixture {
         check("long f(int x, int y) {\n"
               "  return x * y;\n"
               "}\n", &settings);
-        ASSERT_EQUALS("[test.cpp:2]: (style) possible loss of information, int result is returned as long value\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:2]: (style) int result is returned as long value. If the return value is long to avoid loss of information, then you have loss of information.\n", errout.str());
 
         // typedef
         check("size_t f(int x, int y) {\n"

Original file line number	Diff line number	Diff line change
`@@ -366,13 +366,15 @@ void CheckType::longCastAssignError(const Token *tok)`
`366`	`366`	`reportError(tok,`
`367`	`367`	`Severity::style,`
`368`	`368`	`"truncLongCastAssignment",`
`369`		`- "possible loss of information, int result is assigned to long variable");`
	`369`	`+ "int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information.\n"`
	`370`	`+ "int result is assigned to long variable. If the variable is long to avoid loss of information, then there is loss of information. To avoid loss of information you must cast a calculation operand to long, for example 'l = a * b;' => 'l = (long)a * b;'.");`
`370`	`371`	`}`
`371`	`372`
`372`	`373`	`void CheckType::longCastReturnError(const Token *tok)`
`373`	`374`	`{`
`374`	`375`	`reportError(tok,`
`375`	`376`	`Severity::style,`
`376`	`377`	`"truncLongCastReturn",`
`377`		`- "possible loss of information, int result is returned as long value");`
	`378`	`+ "int result is returned as long value. If the return value is long to avoid loss of information, then you have loss of information.\n"`
	`379`	`+ "int result is returned as long value. If the return value is long to avoid loss of information, then there is loss of information. To avoid loss of information you must cast a calculation operand to long, for example 'return ab;' => 'return (long)ab'.");`
`378`	`380`	`}`