Enable Open Here context menu on Windows to work with root of a drive#8287
Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom Nov 19, 2018
Merged
Enable Open Here context menu on Windows to work with root of a drive#8287TravisEz13 merged 2 commits intoPowerShell:masterfrom
Open Here context menu on Windows to work with root of a drive#8287TravisEz13 merged 2 commits intoPowerShell:masterfrom
Conversation
b26c80a to
8abda7d
Compare
TravisEz13
approved these changes
Nov 16, 2018
bergmeister
reviewed
Nov 16, 2018
Contributor
bergmeister
left a comment
There was a problem hiding this comment.
Since this problem is Windows specific wouldn't it make sense to expose -RemoveWorkingDirectoryTrailingCharacter only on Windows?
Member
Author
|
@bergmeister good point, I'll update |
iSazonov
pushed a commit
to iSazonov/PowerShell
that referenced
this pull request
Nov 29, 2018
…ve (PowerShell#8287) support being started by Windows Shell (Open Here) where a trailing slash followed by a quote is handled incorrectly
14 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The fundamental problem is that Microsoft cpp command line parsing rules indicate that a backslash followed by a quote is a quote, otherwise, it is literal. So this:
Is received as
c:"at argument parsing time. Of course, this is a bit more complicated asOpen Herealso uses-Command. So:Becomes
c:" -command 1+1as the argument value to-workingdirectory. And-commandmust be last in the command line.Fix is to add a hidden switch for the purpose of the
Open Herecontext menu called-RemoveWorkingDirectoryTrailingCharacter. This allowsOpen Here's command line to pad the path:Now all the args can get parsed appropriately as the working directory path never ends with a trailing backslash.
Fix #8278
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests