Skip to content

Add fallback to session state if function definition in Ast is broken in PseudoBinding #27616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MartinGC94 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add fallback to session state if function definition in Ast is broken in PseudoBinding #27616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8a02c4
Add fallback to session state if function definition in Ast is broken
MartinGC94 Jun 20, 2026
f686e97
Apply suggestions from code review
MartinGC94 Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,7 +1198,17 @@ private bool PrepareCommandElements(ExecutionContext context, CommandParameterAs
string commandName = null;
try
{
processor = PrepareFromAst(context, out commandName) ?? context.CreateCommand(commandName, dotSource, forCompletion:true);
processor = PrepareFromAst(context, out commandName);
}
catch (RuntimeException)
{
// There's an issue with the function definition.
// We ignore it because an older working definition can have been loaded into the session state already.
}

try
{
processor ??= context.CreateCommand(commandName, dotSource, forCompletion: true);
}
catch (RuntimeException)
{
Expand Down
56 changes: 56 additions & 0 deletions test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3877,6 +3877,62 @@ function MyFunction ($param1, $param2)
$res = TabExpansion2 -inputScript $Text -cursorColumn ($Text.Length - 1)
$res.CompletionMatches | Should -HaveCount 0
}

Context "Tab completion with broken function definition" {
BeforeAll {
# First define and load a working version of the function
function BrokenFunctionTest
{
[OutputType([string])]
param
(
[Parameter()]
[string]
$Param1
)
}
}

AfterAll {
Remove-Item function:BrokenFunctionTest -ErrorAction SilentlyContinue
}

It 'Should complete parameters of a function with missing types' {
$res = TabExpansion2 -inputScript @'
function BrokenFunctionTest
{
[OutputType([THISTYPEDOESNOTEXIST])]
param
(
[Parameter()]
[THISTYPEDOESNOTEXIST]
$Param1
)
}

BrokenFunctionTest -Param
'@
$res.CompletionMatches[0].CompletionText | Should -BeExactly '-Param1'
}

It 'Should complete output members from a function with missing types' {
$res = TabExpansion2 -inputScript @'
function BrokenFunctionTest
{
[OutputType([THISTYPEDOESNOTEXIST])]
param
(
[Parameter()]
[THISTYPEDOESNOTEXIST]
$Param1
)
}

(BrokenFunctionTest).Lengt
'@
$res.CompletionMatches[0].CompletionText | Should -BeExactly 'Length'
}
}
}

Describe "TabCompletion elevated tests" -Tags CI, RequireAdminOnWindows {
Expand Down