Add comprehensive ConvertTo-Json depth and multilevel composition tests#26744
Merged
daxian-dbw merged 3 commits intoPowerShell:masterfrom Feb 10, 2026
Merged
Conversation
Collaborator
|
@yotsuda Please resolve merge conflict. In other PR too. |
yotsuda
force-pushed
the
add-convertto-json-depth-multilevel-tests
branch
from
daaec64 to
f2a4a2e
Compare
Contributor
Author
|
@iSazonov Thank you for letting me know. I have rebased both PRs onto the latest master to resolve the merge conflicts. |
iSazonov
added
the
CL-Test
iSazonov
reviewed
Feb 6, 2026
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Show resolved
Hide resolved
yotsuda
added a commit
to yotsuda/PowerShell
that referenced
this pull request
Feb 6, 2026
iSazonov
reviewed
Feb 6, 2026
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Feb 6, 2026
iSazonov
added
the
Approved-LowRisk
Member
Collaborator
|
@yotsuda Please resolve merge conflicts. |
…o-Json Add 34 new Pester tests covering: - Depth parameter basic behavior (default and explicit depth values) - Depth truncation with arrays and hashtables - Depth truncation string representations - Multilevel compositions (Array/Dictionary/PSCustomObject/Class) - Complex nested mixed type structures - Pipeline vs InputObject behavior This is Phase 4 of the test plan from PR PowerShell#26639. Co-Authored-By: Claude <[email protected]>
- Add truncation test for PowerShell class at Depth limit - Update all Phase 4 tests to verify both Pipeline and InputObject - Remove dedicated Pipeline vs InputObject Context Co-Authored-By: Claude Opus 4.6 <[email protected]>
yotsuda
force-pushed
the
add-convertto-json-depth-multilevel-tests
branch
from
13c77c8 to
e9b1545
Compare
Contributor
Author
|
@daxian-dbw @iSazonov Thanks!! |
daxian-dbw
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add comprehensive depth truncation and multilevel composition tests for
ConvertTo-Json(Phase 4).PR Context
This is a follow-up to #26639. Per @iSazonov's suggestion, comprehensive tests are being submitted as separate PRs for each phase.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerTests Added
The following depth truncation and multilevel composition tests are added to
ConvertTo-Json.Tests.ps1:Total: 34 new tests