Skip to content

Add missing application.json#541

Merged
plata merged 1 commit into
PhoenicisOrg:masterfrom
plata:application-json
Apr 6, 2018
Merged

Add missing application.json#541
plata merged 1 commit into
PhoenicisOrg:masterfrom
plata:application-json

Conversation

@plata

@plata plata commented Apr 1, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

@madoar

madoar commented Apr 1, 2018

Copy link
Copy Markdown
Collaborator

Why do we need to add application.json files for these scripts?

@plata

plata commented Apr 2, 2018

Copy link
Copy Markdown
Collaborator Author

It's just to be consistent. If we want to specify the id explicitly instead of using the one which is generated in Java, we must have these application.json. So e.g. if we decide to use lower case IDs, this is also the place which must be changed.

@plata plata merged commit 13df06d into PhoenicisOrg:master Apr 6, 2018
@plata plata deleted the application-json branch April 6, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants