Skip to content

Commit 4d062a5

Browse files
appium#594 FIX: The final commit
- AppiumCommandInfo was added. - constructors of AndroidDriver were changed.
1 parent aaeee64 commit 4d062a5

6 files changed

Lines changed: 52 additions & 16 deletions

File tree

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
/*
2+
* Licensed under the Apache License, Version 2.0 (the "License");
3+
* you may not use this file except in compliance with the License.
4+
* See the NOTICE file distributed with this work for additional
5+
* information regarding copyright ownership.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
package io.appium.java_client;
17+
18+
import org.openqa.selenium.remote.CommandInfo;
19+
import org.openqa.selenium.remote.http.HttpMethod;
20+
21+
public class AppiumCommandInfo extends CommandInfo {
22+
private final String url;
23+
private final HttpMethod method;
24+
25+
public AppiumCommandInfo(String url, HttpMethod method) {
26+
super(url, method);
27+
this.url = url;
28+
this.method = method;
29+
}
30+
31+
public String getUrl() {
32+
return url;
33+
}
34+
35+
public HttpMethod getMethod() {
36+
return method;
37+
}
38+
}

src/main/java/io/appium/java_client/AppiumDriver.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
import org.openqa.selenium.remote.DriverCommand;
4545
import org.openqa.selenium.remote.ErrorHandler;
4646
import org.openqa.selenium.remote.ExecuteMethod;
47-
import org.openqa.selenium.remote.HttpCommandExecutor;
4847
import org.openqa.selenium.remote.Response;
4948
import org.openqa.selenium.remote.html5.RemoteLocationContext;
5049
import org.openqa.selenium.remote.http.HttpClient;
@@ -85,7 +84,7 @@ public class AppiumDriver<T extends WebElement>
8584
* @param capabilities take a look
8685
* at {@link org.openqa.selenium.Capabilities}
8786
*/
88-
public AppiumDriver(HttpCommandExecutor executor, Capabilities capabilities) {
87+
public AppiumDriver(AppiumCommandExecutor executor, Capabilities capabilities) {
8988
super(executor, capabilities);
9089
this.executeMethod = new AppiumExecutionMethod(this);
9190
locationContext = new RemoteLocationContext(executeMethod);

src/main/java/io/appium/java_client/MobileCommand.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import com.google.common.collect.ImmutableMap;
2020

2121
import org.apache.commons.lang3.StringUtils;
22-
import org.openqa.selenium.remote.CommandInfo;
2322
import org.openqa.selenium.remote.http.HttpMethod;
2423

2524
import java.util.AbstractMap;
@@ -77,7 +76,7 @@ public class MobileCommand {
7776
protected static final String GET_SETTINGS;
7877
protected static final String SET_SETTINGS;
7978

80-
public static final Map<String, CommandInfo> commandRepository;
79+
public static final Map<String, AppiumCommandInfo> commandRepository;
8180

8281
static {
8382
RESET = "reset";
@@ -184,8 +183,8 @@ public class MobileCommand {
184183
* @param url is the command URL
185184
* @return an instance of {@link org.openqa.selenium.remote.CommandInfo}
186185
*/
187-
public static CommandInfo getC(String url) {
188-
return new CommandInfo(url, HttpMethod.GET);
186+
public static AppiumCommandInfo getC(String url) {
187+
return new AppiumCommandInfo(url, HttpMethod.GET);
189188
}
190189

191190
/**
@@ -194,8 +193,8 @@ public static CommandInfo getC(String url) {
194193
* @param url is the command URL
195194
* @return an instance of {@link org.openqa.selenium.remote.CommandInfo}
196195
*/
197-
public static CommandInfo postC(String url) {
198-
return new CommandInfo(url, HttpMethod.POST);
196+
public static AppiumCommandInfo postC(String url) {
197+
return new AppiumCommandInfo(url, HttpMethod.POST);
199198
}
200199

201200
/**
@@ -204,8 +203,8 @@ public static CommandInfo postC(String url) {
204203
* @param url is the command URL
205204
* @return an instance of {@link org.openqa.selenium.remote.CommandInfo}
206205
*/
207-
public static CommandInfo deleteC(String url) {
208-
return new CommandInfo(url, HttpMethod.DELETE);
206+
public static AppiumCommandInfo deleteC(String url) {
207+
return new AppiumCommandInfo(url, HttpMethod.DELETE);
209208
}
210209

211210
/**

src/main/java/io/appium/java_client/android/AndroidDriver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@
2525
import io.appium.java_client.FindsByAndroidUIAutomator;
2626
import io.appium.java_client.PressesKeyCode;
2727
import io.appium.java_client.TouchAction;
28+
import io.appium.java_client.remote.AppiumCommandExecutor;
2829
import io.appium.java_client.remote.MobilePlatform;
2930
import io.appium.java_client.service.local.AppiumDriverLocalService;
3031
import io.appium.java_client.service.local.AppiumServiceBuilder;
3132
import org.openqa.selenium.Capabilities;
3233
import org.openqa.selenium.WebElement;
33-
import org.openqa.selenium.remote.HttpCommandExecutor;
3434
import org.openqa.selenium.remote.http.HttpClient;
3535

3636
import java.net.URL;
@@ -59,7 +59,7 @@ public class AndroidDriver<T extends WebElement>
5959
* @param capabilities take a look
6060
* at {@link org.openqa.selenium.Capabilities}
6161
*/
62-
public AndroidDriver(HttpCommandExecutor executor, Capabilities capabilities) {
62+
public AndroidDriver(AppiumCommandExecutor executor, Capabilities capabilities) {
6363
super(executor, substituteMobilePlatform(capabilities, ANDROID_PLATFORM));
6464
}
6565

src/main/java/io/appium/java_client/ios/IOSDriver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@
2323
import io.appium.java_client.FindsByIosUIAutomation;
2424
import io.appium.java_client.HidesKeyboardWithKeyName;
2525
import io.appium.java_client.TouchAction;
26+
import io.appium.java_client.remote.AppiumCommandExecutor;
2627
import io.appium.java_client.remote.MobilePlatform;
2728
import io.appium.java_client.service.local.AppiumDriverLocalService;
2829
import io.appium.java_client.service.local.AppiumServiceBuilder;
2930
import org.openqa.selenium.Alert;
3031
import org.openqa.selenium.Capabilities;
3132
import org.openqa.selenium.WebElement;
3233
import org.openqa.selenium.remote.DriverCommand;
33-
import org.openqa.selenium.remote.HttpCommandExecutor;
3434
import org.openqa.selenium.remote.Response;
3535
import org.openqa.selenium.remote.http.HttpClient;
3636
import org.openqa.selenium.security.Credentials;
@@ -61,7 +61,7 @@ public class IOSDriver<T extends WebElement>
6161
* @param capabilities take a look
6262
* at {@link org.openqa.selenium.Capabilities}
6363
*/
64-
public IOSDriver(HttpCommandExecutor executor, Capabilities capabilities) {
64+
public IOSDriver(AppiumCommandExecutor executor, Capabilities capabilities) {
6565
super(executor, substituteMobilePlatform(capabilities, IOS_PLATFORM));
6666
}
6767

src/main/java/io/appium/java_client/windows/WindowsDriver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@
2222
import io.appium.java_client.FindsByWindowsAutomation;
2323
import io.appium.java_client.HidesKeyboardWithKeyName;
2424
import io.appium.java_client.PressesKeyCode;
25+
import io.appium.java_client.remote.AppiumCommandExecutor;
2526
import io.appium.java_client.service.local.AppiumDriverLocalService;
2627
import io.appium.java_client.service.local.AppiumServiceBuilder;
2728
import org.openqa.selenium.Capabilities;
2829
import org.openqa.selenium.WebElement;
29-
import org.openqa.selenium.remote.HttpCommandExecutor;
3030
import org.openqa.selenium.remote.http.HttpClient;
3131

3232
import java.net.URL;
@@ -35,7 +35,7 @@ public class WindowsDriver<T extends WebElement>
3535
extends AppiumDriver<T> implements PressesKeyCode, HidesKeyboardWithKeyName,
3636
FindsByWindowsAutomation<T> {
3737

38-
public WindowsDriver(HttpCommandExecutor executor, Capabilities capabilities) {
38+
public WindowsDriver(AppiumCommandExecutor executor, Capabilities capabilities) {
3939
super(executor, substituteMobilePlatform(capabilities, WINDOWS));
4040
}
4141

0 commit comments

Comments
 (0)