Skip to content

build(zone.js): update changelog of zone.js#31915

Closed
JiaLiPassion wants to merge 2 commits into
angular:masterfrom
JiaLiPassion:changelog-1
Closed

build(zone.js): update changelog of zone.js#31915
JiaLiPassion wants to merge 2 commits into
angular:masterfrom
JiaLiPassion:changelog-1

Conversation

@JiaLiPassion

@JiaLiPassion JiaLiPassion commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

update the changelog pf zone.js

Does this PR introduce a breaking change?

  • Yes
  • No

@JiaLiPassion JiaLiPassion requested review from a team July 30, 2019 21:24
@googlebot

googlebot commented Jul 30, 2019

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@JiaLiPassion JiaLiPassion force-pushed the changelog-1 branch 2 times, most recently from 581f492 to 2759375 Compare August 1, 2019 19:54
gkalpak
gkalpak reviewed Aug 1, 2019
View reviewed changes
Comment thread tools/gulp-tasks/changelog-zonejs.js Outdated
Comment thread tools/gulp-tasks/changelog-zonejs.js Outdated
Comment thread packages/zone.js/DEVELOPER.md Outdated
@JiaLiPassion

JiaLiPassion commented Aug 1, 2019

Copy link
Copy Markdown
Contributor Author

@gkalpak , I updated the PR, update the gulp file to make sure the version is output correctly (zone version instead of angular version), also handle the feedback you give. Thanks!

@JiaLiPassion JiaLiPassion force-pushed the changelog-1 branch 5 times, most recently from 12b80f4 to 76eccfe Compare August 2, 2019 00:38
@googlebot

googlebot commented Aug 2, 2019

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 2, 2019
@googlebot

googlebot commented Aug 2, 2019

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 2, 2019
@JiaLiPassion JiaLiPassion force-pushed the changelog-1 branch 2 times, most recently from 4036d04 to 13a05d8 Compare August 2, 2019 11:46
@googlebot

googlebot commented Aug 2, 2019

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 2, 2019
@JiaLiPassion JiaLiPassion requested a review from gkalpak August 2, 2019 12:06
@mhevery mhevery added area: zones Issues related to zone.js action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Aug 2, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Aug 2, 2019
@mhevery mhevery added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Aug 2, 2019
alxhub pushed a commit that referenced this pull request Aug 2, 2019
@JiaLiPassion @alxhub
build(zone.js): update changelog of zone.js (#31915)
9789cb6 
PR Close #31915
alxhub pushed a commit that referenced this pull request Aug 2, 2019
@JiaLiPassion @alxhub
build(zone.js): update gulp task to gen changelog automatically (#31915)
dde0a32 
PR Close #31915
@alxhub alxhub closed this in fa4e170 Aug 2, 2019
alxhub pushed a commit that referenced this pull request Aug 2, 2019
@JiaLiPassion @alxhub
build(zone.js): update gulp task to gen changelog automatically (#31915)
2a6e6c0 
PR Close #31915
@snyk-bot snyk-bot mentioned this pull request Aug 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Aug 30, 2019
Open
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@JiaLiPassion @sabeersulaiman
build(zone.js): update changelog of zone.js (angular#31915)
9a5bd08 
PR Close angular#31915
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@JiaLiPassion @sabeersulaiman
build(zone.js): update gulp task to gen changelog automatically (angu…
a2ff109 
…lar#31915)

PR Close angular#31915
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@mhevery mhevery mhevery approved these changes
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@JiaLiPassion @googlebot @mhevery @gkalpak