Conversation
... and remove the FQCN as a class description. If that would leave the class docblock empty, add a perfunctory class description.
…undant-class-docblock-tags Documentation: remove redundant class docblock tags
…ranch/wpengine-image Updated contribution documentation + Removed WPEngine logo
As the Readme is getting quite long, adding a table of contents seems appropriate. Includes adding a mini-section about contributing to the project and fixing a minor grammar error.
Readme: add table of contents
The `$ooScopeTokens` property is not intended to be set via a custom ruleset, so the property should never have been `public`.
* Hex numbers were already handled correctly, but there was no unit test safe guarding the case-insensitive matching.
* Binary numbers using an uppercase `B` were _not_ handled correctly so far.
This has been fixed, including adding a unit test to safe guard this.
Direct calls to `__clone()` from within a class using `self`, `static` or `parent` were always allowed. Ref: https://3v4l.org/BmmPT
Make the sniff a little faster by skipping over complete docblocks instead of walking them via `findNext()`.
Prevent recognizing class instantiation as if it were a function call. Includes unit test. Fixes 913
Looks like this constant has been in PHP since 7.2, but was previously missed. The constant might not have been listed in the documentation until recently. Ref: * php/php-src@613c8dd
…dd-another-sodium-constant NewConstants: account for SODIUM_CRYPTO_PWHASH_ALG_ARGON2ID13
…yle-constructor-efficiency-fix RemovedPHP4StyleConstructors: efficiency fix
…ne-bugfix NewDirectCallsToClone: bug fix - exclude class internal calls
... picked up along the way.
Check the function docblock for a `@deprecated` tag and if found, bow out. Includes unit tests. Fixes 911
Use FQN for global constants.
CS/QA: minor touch-up
…ocs-fixes Various minor documentation fixes
…ring-param-bugfix ForbiddenToStringParameters: property should not be public
…ug-fix-case-sensitivity ValidIntegers: bug fix - binary and hex numbers are case-insensitive
…-required-params-bugfix RequiredToOptionalFunctionParameters: bug fix for class instantiation
…ecated-functions-by-design ReservedFunctionNames: ignore deprecated functions
Changelog for PHPCompatibility 9.3.2
wimg
approved these changes
Oct 16, 2019
Member
Author
|
Release tweet: https://twitter.com/jrf_nl/status/1184656142951165952 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for tracking changes for the 9.3.2 release. Target release date: Wednesday October 16.
master(careful, GH defaults todevelop!) & copy & paste the changelog to itOpen PR to mergemasterintodevelopto get rid of the This branch is out-of-date with the base branch messages on each release. (only after major releases)