Skip to content

Syntax/RemovedCurlyBraceArrayAccess: prevent false positive on PHP 8.4 property hook declarations#2026

Merged
wimg merged 1 commit intodevelopfrom
feature/syntax-removedcurlybracearrayaccess-false-positive-on-property-hooks
Mar 22, 2026
Merged

Syntax/RemovedCurlyBraceArrayAccess: prevent false positive on PHP 8.4 property hook declarations#2026
wimg merged 1 commit intodevelopfrom
feature/syntax-removedcurlybracearrayaccess-false-positive-on-property-hooks

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Mar 2, 2026

At this time, PHPCS does not (yet) support PHP 8.4 property hook syntax properly, however, we may still encounter the syntax in code under scan.

With this in mind, and as this issue has been reported elsewhere, let's prevent this sniff from throwing a false positive on OO properties declaring PHP 8.4 property hooks.

Includes test.

…4 property hook declarations

At this time, PHPCS does not (yet) support PHP 8.4 property hook syntax properly, however, we may still encounter the syntax in code under scan.

With this in mind, and as this issue has been reported elsewhere, let's prevent this sniff from throwing a false positive on OO properties declaring PHP 8.4 property hooks.

Includes test.
@jrfnl jrfnl added this to the 10.0.0-alpha3 milestone Mar 2, 2026
@jrfnl jrfnl requested a review from wimg March 2, 2026 23:15
@jrfnl jrfnl requested review from wimg and removed request for wimg March 21, 2026 02:00
@wimg wimg merged commit 0d13cee into develop Mar 22, 2026
48 checks passed
@wimg wimg deleted the feature/syntax-removedcurlybracearrayaccess-false-positive-on-property-hooks branch March 22, 2026 22:29
@github-actions github-actions bot removed PR: quick merge PR only contains relatively simple changes PR: ready for review labels Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants