Skip to content

Commit 7c4ac68

Browse files
gkalpakpetebacondarwin
authored andcommitted
build(aio): remove unused script and GitHub token
Since 808bd4a, we are no longer pre-verifying PRs before uploading the build artifacts to the preview server, thus we no longer need the `travis-preverify-pr.sh` script or the `GITHUB_TEAM_MEMBERSHIP_CHECK_KEY` variable.
1 parent 2055634 commit 7c4ac68

4 files changed

Lines changed: 4 additions & 41 deletions

File tree

aio/aio-builds-setup/docs/misc--integrate-with-ci.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@
33

44
TODO (gkalpak): Add docs. Mention:
55
- Travis' JWT addon (+ limitations).
6-
Relevant files: `.travis.yml`
6+
Relevant files: `.travis.yml`, `scripts/ci/env.sh`
77
- Testing on CI.
8-
Relevant files: `ci/test-aio.sh`, `aio/aio-builds-setup/scripts/test.sh`
9-
- Preverifying on CI.
10-
Relevant files: `ci/deploy.sh`, `aio/aio-builds-setup/scripts/travis-preverify-pr.sh`
8+
Relevant files: `scripts/ci/test-aio.sh`, `aio/aio-builds-setup/scripts/test.sh`
119
- Deploying from CI.
12-
Relevant files: `ci/deploy.sh`, `aio/scripts/deploy-preview.sh`
10+
Relevant files: `scripts/ci/deploy.sh`, `aio/scripts/deploy-preview.sh`,
11+
`aio/scripts/deploy-to-firebase.sh`

aio/aio-builds-setup/docs/overview--scripts-and-commands.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,6 @@ available:
1616
Can be used for running the tests for `<aio-builds-setup-dir>/dockerbuild/scripts-js/`. This is
1717
useful for CI integration. See [here](misc--integrate-with-ci.md) for more info.
1818

19-
- `travis-preverify-pr.sh`:
20-
Can be used for "pre-verifying" a PR before uploading the artifacts to the server. It checks
21-
whether the author of the PR is a member of one of the specified GitHub teams (therefore allowed
22-
to upload build artifacts) or the PR has the specified "trusted PR" label (meaning it has been
23-
manually verified by a trusted member). This is useful for CI integration.
24-
See [here](misc--integrate-with-ci.md) for more info.
25-
2619
- `update-preview-server.sh`:
2720
Can be used for updating the docker container (and image) based on the latest changes checked out
2821
from a git repository. See [here](vm-setup--update-docker-container.md) for more info.

aio/aio-builds-setup/scripts/travis-preverify-pr.sh

Lines changed: 0 additions & 26 deletions
This file was deleted.

scripts/ci/env.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,6 @@ if [[ ${TRAVIS:-} ]]; then
8484
# WARNING: NGBUILDS_IO_KEY should NOT be printed
8585
export NGBUILDS_IO_KEY=${NGBUILDS_IO_KEY:-$SAUCE_ACCESS_KEY}
8686

87-
# Personal token generated by mary-poppins, with only `read_org` permission
88-
export GITHUB_TEAM_MEMBERSHIP_CHECK_KEY=35fc4093c1f29a2ddaf60cce5d57065454180bf6
89-
9087
# Used by karma and karma-chrome-launcher
9188
# In order to have a meaningful SauceLabs badge on the repo page,
9289
# the angular2-ci account is used only when pushing commits to master;

0 commit comments

Comments
 (0)