Conversation
Using nativescript-dev-webpack and @ngtools/webpack plugins.
tjvantoll
reviewed
Feb 6, 2017
Contributor
tjvantoll
left a comment
tjvantoll
left a comment
There was a problem hiding this comment.
Looks good. One minor note: on iOS when I run the app with webpack bundling the status bar code doesn’t work for some reason.
I don’t think that should hold this up as it’s rather trivial (and works fine on Android), but I thought I’d mention it in case if you have any ideas what might be going on.
| ], | ||
| bootstrap: [AppComponent] | ||
| bootstrap: [AppComponent], | ||
| schemas: [NO_ERRORS_SCHEMA] |
Contributor
There was a problem hiding this comment.
Out of curiosity, why is this necessary?
Contributor
|
Here’s what I see on iOS.
|
Contributor
|
The white status-bar turned out to be caused by webpack not handling the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #213