This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: avoid duplicate modules from tns-core-modules and @nativescript/core#1103
Merged
rosen-vladimirov merged 2 commits intomasterfrom Dec 4, 2019
Merged
Conversation
rosen-vladimirov
approved these changes
Dec 3, 2019
…core causing app crashes on Android The AngularCompilerPlugin is resolving the files based on the `paths` property from the tsconfig and we have to unify the core modules package name in order to avoid duplicate modules.
ba9b772 to
b74b231
Compare
|
test --webpack-apps |
Contributor
Author
|
test --webpack-apps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AngularCompilerPlugin is resolving the files based on the
pathsproperty from the tsconfig and we have to unify the core modules package name in order to avoid duplicate modules causing app crashes on Android.PR Checklist
What is the current behavior?
vendor.jscontains both the@nativescrip/core/ui/applicationand the proxytns-core-modules/ui/applicationin Angular apps with short imports support in theirtsconfig:What is the new behavior?
We are processing the
tsconfigpaths and unifying the core modules package name in order too keep a single package name in the generated code.Related to: may failing Angular related e2e tests