feat: use node logic for globals and modules#215
Merged
edusperoni merged 3 commits intomainfrom Jul 24, 2023
Merged
Conversation
6935a1e to
88e9e1c
Compare
Merged
NathanWalker
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft on how new modules and globals could work
Instead of calling Init manually on the runtime, each module would register itself either as a global (
NODE_BINDING_PER_ISOLATE_INIT_OBJ) or as a node module (NODE_BINDING_CONTEXT_AWARE_INTERNAL).Globals are already working, we still need work for the node modules (essentially check if a module is a native module and call it + cache it).
This will allow us to
require('ns:crypto'), for example. In the future, we could even rework the way we use native libraries so you can do:import { NSString } from 'ns:native:Foundation'to get a slimmer app size and automatic metadata filtering through bundlersNativeScript/NativeScript#195