Tweak VectorOperation/SpanTest exception validation (microsoft#533)

stephentoub · web-flow · commit dabf7a9915a5 · 2023-04-19T18:01:05.000Z
### Motivation and Context
Fix some unit tests to validate what they intended to validate.

### Description
The validation is ensuring if an exception is thrown that it's of the
right type, but it's not actually ensuring that an exception is thrown.

For the array-based validation, we can just use the Assert.Throws
helper.

For the ref struct-based validation, we can't capture the ref structs
into a lambda, but we can at least assert that the operation throws.
diff --git a/dotnet/src/SemanticKernel.UnitTests/VectorOperations/VectorOperationTests.cs b/dotnet/src/SemanticKernel.UnitTests/VectorOperations/VectorOperationTests.cs
@@ -56,14 +56,7 @@ public void ItThrowsOnCosineSimilarityWithDifferentLengthVectorsFP()
         var shortVector = new float[] { -1.0F, 4.0F };
 
         // Assert
-        try
-        {
-            shortVector.CosineSimilarity(this._floatV2);
-        }
-        catch (ArgumentException target)
-        {
-            Assert.IsType<ArgumentException>(target);
-        }
+        Assert.Throws<ArgumentException>(() => shortVector.CosineSimilarity(this._floatV2));
     }
 
     [Fact]
@@ -73,14 +66,7 @@ public void ItThrowsOnCosineSimilarityWithDifferentLengthVectorsDouble()
         var shortVector = new double[] { -1.0, 4.0 };
 
         // Assert
-        try
-        {
-            shortVector.CosineSimilarity(this._doubleV2);
-        }
-        catch (ArgumentException target)
-        {
-            Assert.IsType<ArgumentException>(target);
-        }
+        Assert.Throws<ArgumentException>(() => shortVector.CosineSimilarity(this._doubleV2));
     }
 
     [Fact]
diff --git a/dotnet/src/SemanticKernel.UnitTests/VectorOperations/VectorSpanTests.cs b/dotnet/src/SemanticKernel.UnitTests/VectorOperations/VectorSpanTests.cs
@@ -71,6 +71,7 @@ public void ItThrowsOnCosineSimilarityWithDifferentLengthVectorsFloat()
         try
         {
             vSpan1.CosineSimilarity(vSpan2);
+            Assert.True(false, "No exception thrown");
         }
         catch (ArgumentException target)
         {
@@ -89,6 +90,7 @@ public void ItThrowsOnCosineSimilarityWithDifferentLengthVectorsDouble()
         try
         {
             vSpan1.CosineSimilarity(vSpan2);
+            Assert.True(false, "No exception thrown");
         }
         catch (ArgumentException target)
         {
@@ -161,6 +163,7 @@ public void ItThrowsOnDotProductWithDifferentLengthVectorsFP()
         try
         {
             vSpan1.Dot(vSpan2);
+            Assert.True(false, "No exception thrown");
         }
         catch (ArgumentException target)
         {
@@ -179,6 +182,7 @@ public void ItThrowsOnDotProductWithDifferentLengthVectorsDouble()
         try
         {
             vSpan1.Dot(vSpan2);
+            Assert.True(false, "No exception thrown");
         }
         catch (ArgumentException target)
         {

Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,7 @@ public void ItThrowsOnCosineSimilarityWithDifferentLengthVectorsFloat()`
`71`	`71`	`try`
`72`	`72`	`{`
`73`	`73`	`vSpan1.CosineSimilarity(vSpan2);`
	`74`	`+ Assert.True(false, "No exception thrown");`
`74`	`75`	`}`
`75`	`76`	`catch (ArgumentException target)`
`76`	`77`	`{`
`@@ -89,6 +90,7 @@ public void ItThrowsOnCosineSimilarityWithDifferentLengthVectorsDouble()`
`89`	`90`	`try`
`90`	`91`	`{`
`91`	`92`	`vSpan1.CosineSimilarity(vSpan2);`
	`93`	`+ Assert.True(false, "No exception thrown");`
`92`	`94`	`}`
`93`	`95`	`catch (ArgumentException target)`
`94`	`96`	`{`
`@@ -161,6 +163,7 @@ public void ItThrowsOnDotProductWithDifferentLengthVectorsFP()`
`161`	`163`	`try`
`162`	`164`	`{`
`163`	`165`	`vSpan1.Dot(vSpan2);`
	`166`	`+ Assert.True(false, "No exception thrown");`
`164`	`167`	`}`
`165`	`168`	`catch (ArgumentException target)`
`166`	`169`	`{`
`@@ -179,6 +182,7 @@ public void ItThrowsOnDotProductWithDifferentLengthVectorsDouble()`
`179`	`182`	`try`
`180`	`183`	`{`
`181`	`184`	`vSpan1.Dot(vSpan2);`
	`185`	`+ Assert.True(false, "No exception thrown");`
`182`	`186`	`}`
`183`	`187`	`catch (ArgumentException target)`
`184`	`188`	`{`