Hash#== performs numeric conversions, like built-in Ruby classes

alexdowad · alexdowad · commit ff45510c74ba · 2019-05-16T20:19:06.000+02:00
diff --git a/lib/immutable/enumerable.rb b/lib/immutable/enumerable.rb
@@ -107,7 +107,7 @@ def <=>(other)
     # Return true if `other` contains the same elements, in the same order.
     # @return [Boolean]
     def ==(other)
-      self.eql?(other) || other.respond_to?(:to_ary) && to_ary.eql?(other.to_ary)
+      self.eql?(other) || (other.respond_to?(:to_ary) && to_ary == other.to_ary)
     end
 
     # Convert all the elements into strings and join them together, separated by
diff --git a/lib/immutable/hash.rb b/lib/immutable/hash.rb
@@ -771,7 +771,7 @@ def eql?(other)
     # @param other [Object] The object to compare with
     # @return [Boolean]
     def ==(other)
-      self.eql?(other) || (other.respond_to?(:to_hash) && to_hash.eql?(other.to_hash))
+      self.eql?(other) || (other.respond_to?(:to_hash) && to_hash == other.to_hash)
     end
 
     # Return true if this `Hash` is a proper superset of `other`, which means
diff --git a/spec/lib/immutable/hash/eql_spec.rb b/spec/lib/immutable/hash/eql_spec.rb
@@ -1,4 +1,5 @@
 require "spec_helper"
+require "bigdecimal"
 
 describe Immutable::Hash do
   let(:hash) { H["A" => "aye", "B" => "bee", "C" => "see"] }
@@ -33,6 +34,11 @@
       instance = subclass.new("A" => "aye", "B" => "bee", "C" => "see")
       (hash == instance).should == true
     end
+
+    it "performs numeric conversions between floats and BigDecimals" do
+      expect(H[a: 0.0] == H[a: BigDecimal('0.0')]).to be true
+      expect(H[a: BigDecimal('0.0')] == H[a: 0.0]).to be true
+    end
   end
 
   [:eql?, :==].each do |method|
