Added copyrighter, tests, and pre-commit hooks.#1
Conversation
| if not match: | ||
| return None, None | ||
|
|
||
| start_year = int(match.group()[14:18]) |
There was a problem hiding this comment.
suggest adding a comment about how end_year will eq start_year if there is no (-dddd) in the line
copyrighter/copyrighter.py
Outdated
| @@ -0,0 +1,250 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
the python linting checks that run on nimble should also run in this repo
There was a problem hiding this comment.
Yeah i'm working on setting that up now. I did check these file with the nimble linting before moving it over here
There was a problem hiding this comment.
I've added pre-commit to this PR. Github actions is not setup to call pre-commit automatically.
There was a problem hiding this comment.
Ok now github actions calls it automatically
|
I've added pre-commit to this PR. It is not automatically called by CI yet. |
|
I've added CI unit tests to this PR. |
|
CI now calls pre-commit automatically |
Cleaned up github actions.
alexkfreed
force-pushed
the
feature/copyrighter
branch
from
2865817 to
a8f0adc
Compare
alexkfreed
force-pushed
the
feature/copyrighter
branch
from
30ca2ec to
e17e1a9
Compare
alexkfreed
force-pushed
the
feature/copyrighter
branch
from
e17e1a9 to
d5d9f03
Compare
The basic github token doesn't allow a workflow's commit to re-trigger the workflow. (The CI actions won't run on the pre-commit fixes). Added tibdex/github-app-token@v1 to the workflow. Some setup must also be done in the repo: > go to GitHub > megh-pre-commit-agent > generate a private key (or reuse existing one) > copy private key and app id > go to repo > settings > secrets > actions > name: PRE_COMMIT_AGENT_APP_ID, value: ___ > name: PRE_COMMIT_AGENT_PRIVATE_KEY, value: ___
alexkfreed
force-pushed
the
feature/copyrighter
branch
from
6399a70 to
1ff410a
Compare
|
@BTOdell let's close out this PR and I can setup the proper python installation in the next PR |
Added * copyrighter * unit tests for copyrighter * pre-commit hooks for other repos to use copyrighter * pre-commit configuration for this repo * github workflow to run pre-commit in this repo. It runs only on files changed in the triggering PR * github workflow to run unit tests in this repo
3 participants
No description provided.