Upgrade Grade Breakdown Summary Table to react-table v8#7800
Merged
david-yz-liu merged 14 commits intoJan 27, 2026
Merged
Conversation
…to allow for sorting by position
… existing tables using columnVisibility
…r if the table has no filters enabled)
Collaborator
Pull Request Test Coverage Report for Build 21368497010Details
💛 - Coveralls |
| const columns = [ | ||
| columnHelper.accessor("position", { | ||
| id: "position", | ||
| header: () => null, |
Collaborator
There was a problem hiding this comment.
All of the rendering attributes are unnecessary, as the column will be hidden through the visibility setting.
| header: () => null, | ||
| cell: () => null, | ||
| size: 0, | ||
| enableSorting: true, |
Collaborator
There was a problem hiding this comment.
Do not enable sorting for any columns; instead we'll keep the order fixed to be the position order (which matches what is shown in the grading view)
david-yz-liu
approved these changes
Jan 27, 2026
david-yz-liu
left a comment
david-yz-liu
left a comment
Collaborator
There was a problem hiding this comment.
Nice work, @lizzie-liu!
Naragod
pushed a commit
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
GradeBreakdownChartto use @tanstack/react-table v8Tablecomponent to:initialState.columnVisibilityfor hidden columnsGradeBreakdownChartcomponentScreenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)