Refactoring: Moved helpers into GradeEntryFormsController class and added tests for coverage + correctness#7789
Merged
david-yz-liu merged 7 commits intoJan 18, 2026
Conversation
Collaborator
Pull Request Test Coverage Report for Build 21104237473Details
💛 - Coveralls |
david-yz-liu
left a comment
Collaborator
There was a problem hiding this comment.
@Karl-Michaud great, I just left a few comments about the test cases you added
david-yz-liu
approved these changes
Jan 18, 2026
david-yz-liu
left a comment
Collaborator
There was a problem hiding this comment.
Nice work, @Karl-Michaud!
Naragod
pushed a commit
that referenced
this pull request
Feb 6, 2026
Also removed old GradeEntryFormsHelper module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR includes the following:
1) Refactor
GradeEntryFormsHelperintoGradeEntryFormsController, which is the more appropriate and conventional location for this behavior.GradeEntryFormsHelper2) Tests
update_grade_entry_form_paramshelper (now located inGradeEntryFormsControllerclass).nameandout_offields are deleted during update.positionvalues after deletion, ensuring ordering logic is correct.See new coverage report:
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)