Fix #10841 FN uninitMemberVar when member is being used in constructor (regression) (danmar#3909)

chrchr-github · web-flow · commit e073860e6234 · 2022-03-16T20:35:55.000+01:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -778,7 +778,7 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio
         }
 
         // Calling member variable function?
-        if (Token::Match(ftok->next(), "%var% . %name% (")) {
+        if (Token::Match(ftok->next(), "%var% . %name% (") && !(ftok->next()->valueType() && ftok->next()->valueType()->pointer)) {
             for (const Variable &var : scope->varlist) {
                 if (var.declarationId() == ftok->next()->varId()) {
                     /** @todo false negative: we assume function changes variable state */
diff --git a/test/testconstructors.cpp b/test/testconstructors.cpp
@@ -179,6 +179,7 @@ class TestConstructors : public TestFixture {
         TEST_CASE(uninitVar31); // ticket #8271
         TEST_CASE(uninitVar32); // ticket #8835
         TEST_CASE(uninitVar33); // ticket #10295
+        TEST_CASE(uninitVar34); // ticket #10841
         TEST_CASE(uninitVarEnum1);
         TEST_CASE(uninitVarEnum2); // ticket #8146
         TEST_CASE(uninitVarStream);
@@ -2822,6 +2823,15 @@ class TestConstructors : public TestFixture {
         ASSERT_EQUALS("[test.cpp:8]: (warning) Member variable 'B::x' is not initialized in the constructor.\n", errout.str());
     }
 
+    void uninitVar34() { // ticket #10841
+        check("struct A { void f() {} };\n"
+              "struct B {\n"
+              "    B() { a->f(); }\n"
+              "    A* a;\n"
+              "};\n");
+        ASSERT_EQUALS("[test.cpp:3]: (warning) Member variable 'B::a' is not initialized in the constructor.\n", errout.str());
+    }
+
     void uninitVarArray1() {
         check("class John\n"
               "{\n"

Original file line number	Diff line number	Diff line change
`@@ -778,7 +778,7 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio`
`778`	`778`	`}`
`779`	`779`
`780`	`780`	`// Calling member variable function?`
`781`		`- if (Token::Match(ftok->next(), "%var% . %name% (")) {`
	`781`	`+ if (Token::Match(ftok->next(), "%var% . %name% (") && !(ftok->next()->valueType() && ftok->next()->valueType()->pointer)) {`
`782`	`782`	`for (const Variable &var : scope->varlist) {`
`783`	`783`	`if (var.declarationId() == ftok->next()->varId()) {`
`784`	`784`	`/** @todo false negative: we assume function changes variable state */`