Skip to content

Commit d163cd6

Browse files
authored
Merge pull request josegonzalez#214 from ZhymabekRoman/master
fix: refactor logging
2 parents fe07d5a + a8a583b commit d163cd6

File tree

2 files changed

+50
-76
lines changed

2 files changed

+50
-76
lines changed

bin/github-backup

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,31 @@
22

33
import os, sys, logging
44

5+
logging.basicConfig(
6+
format='%(asctime)s.%(msecs)03d: %(message)s',
7+
datefmt='%Y-%m-%dT%H:%M:%S',
8+
level=logging.INFO
9+
)
10+
511
from github_backup.github_backup import (
612
backup_account,
713
backup_repositories,
814
check_git_lfs_install,
915
filter_repositories,
1016
get_authenticated_user,
11-
log_info,
12-
log_warning,
17+
logger,
1318
mkdir_p,
1419
parse_args,
1520
retrieve_repositories,
1621
)
1722

18-
logging.basicConfig(
19-
format='%(asctime)s.%(msecs)03d: %(message)s',
20-
datefmt='%Y-%m-%dT%H:%M:%S',
21-
level=logging.INFO
22-
)
2323

2424
def main():
2525
args = parse_args()
2626

2727
output_directory = os.path.realpath(args.output_directory)
2828
if not os.path.isdir(output_directory):
29-
log_info('Create output directory {0}'.format(output_directory))
29+
logger.info('Create output directory {0}'.format(output_directory))
3030
mkdir_p(output_directory)
3131

3232
if args.lfs_clone:
@@ -35,10 +35,10 @@ def main():
3535
if args.log_level:
3636
log_level = logging.getLevelName(args.log_level.upper())
3737
if isinstance(log_level, int):
38-
logging.root.setLevel(log_level)
38+
logger.root.setLevel(log_level)
3939

4040
if not args.as_app:
41-
log_info('Backing up user {0} to {1}'.format(args.user, output_directory))
41+
logger.info('Backing up user {0} to {1}'.format(args.user, output_directory))
4242
authenticated_user = get_authenticated_user(args)
4343
else:
4444
authenticated_user = {'login': None}
@@ -53,5 +53,5 @@ if __name__ == '__main__':
5353
try:
5454
main()
5555
except Exception as e:
56-
log_warning(str(e))
56+
logger.error(str(e))
5757
sys.exit(1)

0 commit comments

Comments
 (0)