You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds support for resolving submodule imports from namespace packages that do not contain __init__.py files.
Previously, imports like from namespace_pkg.domain import model could be treated as external when namespace_pkg/domain/ was a namespace package directory. This change adds a targeted fallback that resolves imported aliases as submodules only when the base import cannot be resolved internally.
Also adds regression tests for absolute and relative namespace-package imports and documents the behavior in the README.
Thanks for the focused change. I found one issue I’d fix before merging.
_resolve_import_targets currently returns only the successfully resolved internal alias targets once any alias resolves. That means a statement like from namespace_pkg.domain import model, remote_model will drop the external/unresolved side if model resolves to namespace_pkg/domain/model.py but remote_model does not resolve internally.
Because this is the core graph extractor, that can hide dependency edges in mixed alias imports. Please preserve an external edge for unresolved aliases, or preserve the original external base edge when not every alias resolves internally, and add a regression test for that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Adds support for resolving submodule imports from namespace packages that do not contain
__init__.pyfiles.Previously, imports like
from namespace_pkg.domain import modelcould be treated as external whennamespace_pkg/domain/was a namespace package directory. This change adds a targeted fallback that resolves imported aliases as submodules only when the base import cannot be resolved internally.Also adds regression tests for absolute and relative namespace-package imports and documents the behavior in the README.
Change Type