Skip to content

Nadia childs#1

Open
LittleBoGeek wants to merge 4 commits intomasterfrom
Nadia-Childs
Open

Nadia childs#1
LittleBoGeek wants to merge 4 commits intomasterfrom
Nadia-Childs

Conversation

@LittleBoGeek
Copy link
Copy Markdown
Owner

No description provided.

@LittleBoGeek LittleBoGeek requested a review from RyanNFreeman June 2, 2019 18:53
Copy link
Copy Markdown
Collaborator

@RyanNFreeman RyanNFreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hit mvp. Good work!

Explicit binding is when the in-built methods call or apply are used.
5. Why do we need super() in an extended class?

super () works with the extends keyword to simplify the process of binding classes together and making use of inheritance. Super makes sure that the parent constructor is accessible to the child's attributes.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answers all look good. With super and extends, it helps to think of extends as the bridge and super is the car that moves things over.





Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.


// Explain in your own words why `nestedfunction()` can access the variable `internal`.
/* */
// Explanation: I believe because when nestedFunction() is invoked it has the ability to reach outside of its scope and access the internal variable even though it's defined outside of the function's scope.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep :)

}

function greeting(a,b){
return `Hello ${a} ${b} , nice to meet you!`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but I'd try to be a little more specific with your naming conventions. function greeting(firstName, lastName){return Hello ${firstName} ${lastName}, nice to meet you!}

};
}

arrCheck(graduates);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with the for loops.


const animalNames = [];
zooAnimals.forEach(function(arr,index){
animalNames.push("Name:" + " " + arr.animal_name + ", " + "Scientific:" + " " + arr.scientific_name + ".");
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Yeah, whatever you feel more comfortable with, string interpolation or template literals (backticks) both get the job done.


/*Test your volume and surfaceArea methods by uncommenting the logs below:*/
console.log(cuboid.volume()); // 100
console.log(cuboid.surfaceArea()); // 130
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants