build(rust): mimalloc-safe/no_opt_arch on aarch64#6072
build(rust): mimalloc-safe/no_opt_arch on aarch64#6072lukastaegert merged 2 commits intorollup:masterfrom
Conversation
initially introduced by rollup#6055 for linux, this did not include android devices as it is considerd its own operating system with linux being the "vendor"; triplets are quite inconsistent and confusing at times! this change conservatively disables arch-specific optimizations for all aarch64 targets, to ensure broad compatibility. closes rollup#6047
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6072 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 271 271
Lines 10598 10599 +1
Branches 2830 2831 +1
=======================================
+ Hits 10470 10471 +1
Misses 88 88
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Hmm, this would also disable optimizations for aarch64-apple-darwin, which is a very common tier 1 target that is also fully tested in every pipeline. I would feel better if we could keep optimizations for this one, what do you think? I agree about the other aarch64 targets, though.
|
Ooh Apple targets are a very good point. Updated the dependency condition :) |
|
This PR has been released as part of [email protected]. You can test it via |
2 participants
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
initially introduced by #6055 for linux, this did not include android devices as it is considerd its own operating system with linux being the "vendor"; triplets are quite inconsistent and confusing at times!
this change conservatively disables arch-specific optimizations for all aarch64 targets, to ensure broad compatibility.