Merged
Conversation
labkey-nicka
reviewed
Dec 2, 2024
labkey-nicka
approved these changes
Dec 3, 2024
Contributor
labkey-nicka
left a comment
labkey-nicka
left a comment
There was a problem hiding this comment.
Thanks for adding those tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds import_rows to the Query API. Accessible via api wrapper as api.query.import_rows. This resolves Issue 50404.
Note: while as far as I can tell this does appear to be the correct implementation I cannot seem to get my server to accept a file when using
importLookupByAlternateKey, it always complains that a string is not an integer, though maybe I am doing something wrong?Related Pull Requests
Changes