Merged
Conversation
select_rows: Set default max_rows to -1
RosalineP
approved these changes
Oct 9, 2023
Contributor
RosalineP
left a comment
RosalineP
left a comment
There was a problem hiding this comment.
Looks good other than the comments/questions I had! Should be simple changes that don't warrant another review, so I'm approving.
| container_path: str = None, | ||
| columns=None, | ||
| max_rows: int = None, | ||
| max_rows: int = -1, |
Contributor
There was a problem hiding this comment.
Down on line 376, should it be if max_rows is not -1?
Contributor
There was a problem hiding this comment.
Seperately, should the @functools.wraps part down on line 525 be updated to -1 as well?
Contributor
Author
There was a problem hiding this comment.
For 376 - No, it needs to remain that way or we'll never pass the default value.
For 525 - Yes, good catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR fixes Issue 48466
Related Pull Requests
Changes