Skip to content

Commit 8b88f28

Browse files
authored
JAVA-2916: Annotate generated classes with @SuppressWarnings (apache#1530)
1 parent 367284f commit 8b88f28

5 files changed

Lines changed: 21 additions & 0 deletions

File tree

changelog/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
### 4.11.0 (in progress)
66

7+
- [improvement] JAVA-2916: Annotate generated classes with `@SuppressWarnings`
78
- [bug] JAVA-2927: Make Dropwizard truly optional
89
- [improvement] JAVA-2917: Include GraalVM substitutions for request processors and geo codecs
910
- [bug] JAVA-2918: Exclude invalid peers from schema agreement checks

mapper-processor/src/main/java/com/datastax/oss/driver/internal/mapper/processor/dao/DaoImplementationGenerator.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import com.datastax.oss.driver.shaded.guava.common.collect.ImmutableMap;
3838
import com.datastax.oss.driver.shaded.guava.common.collect.ImmutableSet;
3939
import com.datastax.oss.driver.shaded.guava.common.collect.Maps;
40+
import com.squareup.javapoet.AnnotationSpec;
4041
import com.squareup.javapoet.ClassName;
4142
import com.squareup.javapoet.CodeBlock;
4243
import com.squareup.javapoet.FieldSpec;
@@ -301,6 +302,10 @@ protected JavaFile.Builder getContents() {
301302
TypeSpec.Builder classBuilder =
302303
TypeSpec.classBuilder(implementationName)
303304
.addJavadoc(JAVADOC_GENERATED_WARNING)
305+
.addAnnotation(
306+
AnnotationSpec.builder(SuppressWarnings.class)
307+
.addMember("value", "\"all\"")
308+
.build())
304309
.addModifiers(Modifier.PUBLIC)
305310
.addSuperinterface(ClassName.get(interfaceElement));
306311

mapper-processor/src/main/java/com/datastax/oss/driver/internal/mapper/processor/entity/EntityHelperGenerator.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import com.datastax.oss.driver.internal.mapper.processor.util.generation.BindableHandlingSharedCode;
2727
import com.datastax.oss.driver.internal.mapper.processor.util.generation.GenericTypeConstantGenerator;
2828
import com.datastax.oss.driver.shaded.guava.common.collect.ImmutableList;
29+
import com.squareup.javapoet.AnnotationSpec;
2930
import com.squareup.javapoet.ClassName;
3031
import com.squareup.javapoet.CodeBlock;
3132
import com.squareup.javapoet.FieldSpec;
@@ -87,6 +88,10 @@ protected JavaFile.Builder getContents() {
8788
TypeSpec.Builder classContents =
8889
TypeSpec.classBuilder(helperName)
8990
.addJavadoc(JAVADOC_GENERATED_WARNING)
91+
.addAnnotation(
92+
AnnotationSpec.builder(SuppressWarnings.class)
93+
.addMember("value", "\"all\"")
94+
.build())
9095
.addModifiers(Modifier.PUBLIC)
9196
.superclass(
9297
ParameterizedTypeName.get(

mapper-processor/src/main/java/com/datastax/oss/driver/internal/mapper/processor/mapper/MapperBuilderGenerator.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.datastax.oss.driver.internal.mapper.processor.GeneratedNames;
2222
import com.datastax.oss.driver.internal.mapper.processor.ProcessorContext;
2323
import com.datastax.oss.driver.internal.mapper.processor.SingleFileCodeGenerator;
24+
import com.squareup.javapoet.AnnotationSpec;
2425
import com.squareup.javapoet.ClassName;
2526
import com.squareup.javapoet.JavaFile;
2627
import com.squareup.javapoet.MethodSpec;
@@ -62,6 +63,10 @@ protected JavaFile.Builder getContents() {
6263
getSessionClass())
6364
.addJavadoc(JAVADOC_PARAGRAPH_SEPARATOR)
6465
.addJavadoc(JAVADOC_GENERATED_WARNING)
66+
.addAnnotation(
67+
AnnotationSpec.builder(SuppressWarnings.class)
68+
.addMember("value", "\"all\"")
69+
.build())
6570
.addModifiers(Modifier.PUBLIC)
6671
.addMethod(
6772
MethodSpec.constructorBuilder()

mapper-processor/src/main/java/com/datastax/oss/driver/internal/mapper/processor/mapper/MapperImplementationGenerator.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.datastax.oss.driver.internal.mapper.processor.SingleFileCodeGenerator;
2525
import com.datastax.oss.driver.internal.mapper.processor.util.NameIndex;
2626
import com.datastax.oss.driver.internal.mapper.processor.util.generation.GeneratedCodePatterns;
27+
import com.squareup.javapoet.AnnotationSpec;
2728
import com.squareup.javapoet.ClassName;
2829
import com.squareup.javapoet.FieldSpec;
2930
import com.squareup.javapoet.JavaFile;
@@ -91,6 +92,10 @@ protected JavaFile.Builder getContents() {
9192
GeneratedNames.mapperBuilder(interfaceElement))
9293
.addJavadoc(JAVADOC_PARAGRAPH_SEPARATOR)
9394
.addJavadoc(JAVADOC_GENERATED_WARNING)
95+
.addAnnotation(
96+
AnnotationSpec.builder(SuppressWarnings.class)
97+
.addMember("value", "\"all\"")
98+
.build())
9499
.addModifiers(Modifier.PUBLIC)
95100
.addSuperinterface(ClassName.get(interfaceElement));
96101

0 commit comments

Comments
 (0)