Skip to content

Fix implicit null deprecations#189

Merged
DannyvdSluijs merged 2 commits intoJsonMapper:mainfrom
guillaumesmo:main
Feb 3, 2025
Merged

Fix implicit null deprecations#189
DannyvdSluijs merged 2 commits intoJsonMapper:mainfrom
guillaumesmo:main

Conversation

@guillaumesmo
Copy link
Contributor

Q A
Branch? main
Bug fix? yes
New feature? no
Deprecations? yes
Tickets
License MIT
Changelog Fix implicit null deprecations
Doc PR N/A

This PR fixes the PHP 8.4 deprecations of the following type:

[info] Deprecated: JsonMapper\JsonMapperFactory::__construct(): Implicitly marking parameter $builder as nullable is deprecated, the explicit nullable type must be used instead
[info] Deprecated: JsonMapper\JsonMapperFactory::create(): Implicitly marking parameter $propertyMapper as nullable is deprecated, the explicit nullable type must be used instead
[info] Deprecated: JsonMapper\Handler\PropertyMapper::__construct(): Implicitly marking parameter $classFactoryRegistry as nullable is deprecated, the explicit nullable type must be used instead
[info] Deprecated: JsonMapper\Handler\PropertyMapper::__construct(): Implicitly marking parameter $nonInstantiableTypeResolver as nullable is deprecated, the explicit nullable type must be used instead
[info] Deprecated: JsonMapper\Handler\PropertyMapper::__construct(): Implicitly marking parameter $casterHelper as nullable is deprecated, the explicit nullable type must be used instead
[info] Deprecated: JsonMapper\Middleware\NamespaceResolver::__construct(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used instead
[info] Deprecated: JsonMapper\JsonMapper::__construct(): Implicitly marking parameter $propertyMapper as nullable is deprecated, the explicit nullable type must be used instead

@coveralls
Copy link

coveralls commented Feb 2, 2025

Coverage Status

coverage: 99.718%. remained the same
when pulling d11d0c0 on guillaumesmo:main
into cffe898 on JsonMapper:main.

@DannyvdSluijs
Copy link
Member

@guillaumesmo thanks for the PR. Looks very good. One small question? Could you format the entry in the changelog like the others?

Once done I can merge and release a new version.

@DannyvdSluijs DannyvdSluijs merged commit 7bc24a2 into JsonMapper:main Feb 3, 2025
18 checks passed
@DannyvdSluijs
Copy link
Member

Version 2.22.3 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants