Skip to content

Commit 59df32c

Browse files
committed
include keytool in distribution and build
1 parent 64f8936 commit 59df32c

File tree

2 files changed

+26
-19
lines changed

2 files changed

+26
-19
lines changed

build/build.xml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
<include name="bin/klist.exe" />
5151
<include name="bin/ktab.exe" />
5252

53-
<include name="bin/keytool" />
53+
<!--<include name="bin/keytool" />-->
5454
<include name="bin/orbd" />
5555
<include name="bin/policytool" />
5656
<include name="bin/rmid" />
@@ -66,7 +66,7 @@
6666
</fileset>
6767

6868
<fileset dir="linux/work/java" id="jre-optional-linux">
69-
<include name="bin/keytool" />
69+
<!--<include name="bin/keytool" />-->
7070
<include name="bin/orbd" />
7171
<include name="bin/policytool" />
7272
<include name="bin/rmid" />
@@ -471,6 +471,13 @@
471471
-->
472472
</bundleapp>
473473

474+
<!-- The 'keytool' file is deleted by our appbundler. Add it back so that
475+
Android signing works properly. (Not modifying our appbundler since
476+
most of the time that appbundler is used, keytool isn't needed. -->
477+
<copy file="${jdk.path.macosx}/Contents/Home/bin/keytool"
478+
todir="macosx/work/Processing.app/Contents/PlugIns/jdk1.7.0_${jdk.update.macosx}.jdk/Contents/Home/jre/bin" />
479+
480+
474481
<copy todir="macosx/work/Processing.app/Contents/Java">
475482
<fileset dir=".." includes="core/library/**" /> <!-- why this? -->
476483
<!--<fileset dir="shared" includes="launch4j/**" />-->

build/macosx/appbundler/src/com/oracle/appbundler/AppBundlerTask.java

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public class AppBundlerTask extends Task {
7878
private boolean highResolutionCapable = true;
7979
// Oracle Java 7 requires 10.7.3 or later, so require it here.
8080
private String minimumSystem = "10.7.3";
81-
// By default, don't embed Java FX.
81+
// By default, don't embed Java FX.
8282
private boolean javafx = false;
8383

8484
// JVM info properties
@@ -174,12 +174,12 @@ public void setMinimumSystem(String minimumSystem) {
174174
this.minimumSystem = minimumSystem;
175175
}
176176

177-
177+
178178
public void setHighResolutionCapable(boolean highResolutionCapable) {
179179
this.highResolutionCapable = highResolutionCapable;
180180
}
181-
182-
181+
182+
183183
public void setJavaFX(boolean javafx) {
184184
this.javafx = javafx;
185185
}
@@ -203,10 +203,10 @@ public void addConfiguredRuntime(FileSet runtime) throws BuildException {
203203

204204
runtime.appendExcludes(new String[] {
205205
"bin/",
206-
206+
207207
// original version, removed entire bin folder
208208
// "jre/bin/",
209-
209+
210210
// remove everything except 'java'
211211
"jre/bin/keytool",
212212
"jre/bin/orbd",
@@ -226,12 +226,12 @@ public void addConfiguredRuntime(FileSet runtime) throws BuildException {
226226
"jre/lib/plugin.jar",
227227
"jre/lib/security/javaws.policy"
228228
});
229-
229+
230230
if (!javafx) {
231231
// http://www.oracle.com/technetwork/java/javase/jdk-7-readme-429198.html
232232
runtime.appendExcludes(new String[] {
233233
"jre/THIRDPARTYLICENSEREADME-JAVAFX.txt",
234-
234+
235235
"jre/lib/javafx.properties",
236236
"jre/lib/jfxrt.jar",
237237
"jre/lib/security/javafx.policy",
@@ -423,7 +423,7 @@ public void execute() throws BuildException {
423423

424424
// Copy icon to Resources folder
425425
copyIcon(resourcesDirectory);
426-
426+
427427
// Copy the bundle/document icons as well
428428
copyBundleIcons(resourcesDirectory);
429429

@@ -446,7 +446,7 @@ private void copyResources(File resourcesDirectory) throws IOException {
446446
if (zipEntry.isDirectory()) {
447447
file.mkdir();
448448
} else {
449-
OutputStream outputStream =
449+
OutputStream outputStream =
450450
new BufferedOutputStream(new FileOutputStream(file), BUFFER_SIZE);
451451
try {
452452
int b = zipInputStream.read();
@@ -554,14 +554,14 @@ private void copyLibraryPathEntries(File macOSDirectory) throws IOException {
554554

555555
private void copyIcon(File resourcesDirectory) throws IOException {
556556
if (iconFile == null) {
557-
copy(getClass().getResource(DEFAULT_ICON_NAME),
557+
copy(getClass().getResource(DEFAULT_ICON_NAME),
558558
new File(resourcesDirectory, DEFAULT_ICON_NAME));
559559
} else {
560560
copy(iconFile, new File(resourcesDirectory, iconFile.getName()));
561561
}
562562
}
563-
564-
563+
564+
565565
private void copyBundleIcons(File resourcesDirectory) throws IOException {
566566
for (BundleDocument bundleDocument : bundleDocuments) {
567567
if (bundleDocument.hasIcon()) {
@@ -570,12 +570,12 @@ private void copyBundleIcons(File resourcesDirectory) throws IOException {
570570
}
571571
}
572572
}
573-
573+
574574

575575
private void writeInfoPlist(File file) throws IOException {
576576
FileOutputStream output = new FileOutputStream(file);
577577
PropertyLister plist = new PropertyLister(output);
578-
578+
579579
// Get started, write all necessary header info and open plist element
580580
plist.writeStartDocument();
581581

@@ -595,15 +595,15 @@ private void writeInfoPlist(File file) throws IOException {
595595
plist.writeProperty("CFBundleVersion", version);
596596
plist.writeProperty("CFBundleSignature", signature);
597597
plist.writeProperty("NSHumanReadableCopyright", copyright);
598-
598+
599599
if (getInfo != null) {
600600
plist.writeProperty("CFBundleGetInfoString", getInfo);
601601
}
602602

603603
if (applicationCategory != null) {
604604
plist.writeProperty("LSApplicationCategoryType", applicationCategory);
605605
}
606-
606+
607607
if (minimumSystem != null) {
608608
plist.writeProperty("LSMinimumSystemVersion", minimumSystem);
609609
}

0 commit comments

Comments
 (0)