Fix #13040 (Import project: compile_commands.json, fail to include header in project root folder) (cppcheck-opensource#6724)

danmar · web-flow · commit e6b00812065c · 2024-08-27T14:32:44.000+02:00
diff --git a/lib/importproject.cpp b/lib/importproject.cpp
@@ -164,7 +164,7 @@ void ImportProject::fsSetIncludePaths(FileSettings& fs, const std::string &basep
         }
 
         if (endsWith(s,'/')) // this is a temporary hack, simplifyPath can crash if path ends with '/'
-            s.erase(s.size() - 1U); // TODO: Use std::string::pop_back() as soon as travis supports it
+            s.pop_back();
 
         if (s.find("$(") == std::string::npos) {
             s = Path::simplifyPath(basepath + s);
@@ -174,7 +174,7 @@ void ImportProject::fsSetIncludePaths(FileSettings& fs, const std::string &basep
         }
         if (s.empty())
             continue;
-        fs.includePaths.push_back(s + '/');
+        fs.includePaths.push_back(s.back() == '/' ? s : (s + '/'));
     }
 }
 
diff --git a/test/testimportproject.cpp b/test/testimportproject.cpp
@@ -62,6 +62,7 @@ class TestImportProject : public TestFixture {
         TEST_CASE(importCompileCommands9);
         TEST_CASE(importCompileCommands10); // #10887: include path with space
         TEST_CASE(importCompileCommands11); // include path order
+        TEST_CASE(importCompileCommands12); // #13040: "directory" is parent directory, relative include paths
         TEST_CASE(importCompileCommandsArgumentsSection); // Handle arguments section
         TEST_CASE(importCompileCommandsNoCommandSection); // gracefully handles malformed json
         TEST_CASE(importCppcheckGuiProject);
@@ -319,6 +320,23 @@ class TestImportProject : public TestFixture {
         ASSERT_EQUALS("/x/abc/", fs.includePaths.back());
     }
 
+    void importCompileCommands12() const { // #13040
+        REDIRECT;
+        constexpr char json[] =
+            R"([{
+               "file": "/x/src/1.c" ,
+               "directory": "/x",
+               "command": "cc -c -I. src/1.c"
+            }])";
+        std::istringstream istr(json);
+        TestImporter importer;
+        ASSERT_EQUALS(true, importer.importCompileCommands(istr));
+        ASSERT_EQUALS(1, importer.fileSettings.size());
+        const FileSettings &fs = importer.fileSettings.front();
+        ASSERT_EQUALS(1, fs.includePaths.size());
+        ASSERT_EQUALS("/x/", fs.includePaths.front());
+    }
+
     void importCompileCommandsArgumentsSection() const {
         REDIRECT;
         constexpr char json[] = "[ { \"directory\": \"/tmp/\","

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ void ImportProject::fsSetIncludePaths(FileSettings& fs, const std::string &basep`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`if (endsWith(s,'/')) // this is a temporary hack, simplifyPath can crash if path ends with '/'`
`167`		`- s.erase(s.size() - 1U); // TODO: Use std::string::pop_back() as soon as travis supports it`
	`167`	`+ s.pop_back();`
`168`	`168`
`169`	`169`	`if (s.find("$(") == std::string::npos) {`
`170`	`170`	`s = Path::simplifyPath(basepath + s);`
`@@ -174,7 +174,7 @@ void ImportProject::fsSetIncludePaths(FileSettings& fs, const std::string &basep`
`174`	`174`	`}`
`175`	`175`	`if (s.empty())`
`176`	`176`	`continue;`
`177`		`- fs.includePaths.push_back(s + '/');`
	`177`	`+ fs.includePaths.push_back(s.back() == '/' ? s : (s + '/'));`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`