make __copy__ methods in cache classes hold locks

ndgrigorian · ndgrigorian · commit 1bc9c3d24e78 · 2026-04-14T21:17:56.000-07:00
diff --git a/dpctl/_sycl_device_factory.pyx b/dpctl/_sycl_device_factory.pyx
@@ -445,7 +445,9 @@ cdef class _DefaultDeviceCache:
     def __copy__(self):
         cdef _DefaultDeviceCache _copy = _DefaultDeviceCache.__new__(
             _DefaultDeviceCache)
-        _copy._update_map(self.__device_map__)
+        # lock must be held to avoid race conditions on map state
+        with self._cache_lock:
+            _copy._update_map(self.__device_map__.copy())
         return _copy
 
 
diff --git a/dpctl/_sycl_queue_manager.pyx b/dpctl/_sycl_queue_manager.pyx
@@ -73,7 +73,9 @@ cdef class _DeviceDefaultQueueCache:
         cdef _DeviceDefaultQueueCache _copy = _DeviceDefaultQueueCache.__new__(
             _DeviceDefaultQueueCache
         )
-        _copy._update_map(self.__device_queue_map__)
+        # lock must be held to avoid race conditions on map state
+        with self._cache_lock:
+            _copy._update_map(self.__device_queue_map__.copy())
         return _copy
 
 

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,9 @@ cdef class _DeviceDefaultQueueCache:`
`73`	`73`	`cdef _DeviceDefaultQueueCache _copy = _DeviceDefaultQueueCache.__new__(`
`74`	`74`	`_DeviceDefaultQueueCache`
`75`	`75`	`)`
`76`		`- _copy._update_map(self.__device_queue_map__)`
	`76`	`+ # lock must be held to avoid race conditions on map state`
	`77`	`+ with self._cache_lock:`
	`78`	`+ _copy._update_map(self.__device_queue_map__.copy())`
`77`	`79`	`return _copy`
`78`	`80`
`79`	`81`