Remove local type aliases of ImageRegionIterator and ImageRegionConstIterator in *.hxx files#5981
Draft
N-Dekker wants to merge 2 commits intoInsightSoftwareConsortium:mainfrom
Conversation
Made it easier to figure out which kind of iterator is being used.
Using Notepad++, Replace in Files, doing:
Find what: ^[ ]+ using (\w+) = (ImageRegionIterator<\w+>);\r\n(.*?[^\w])\1
Replace with: $3$2
Filters: itk*.hxx
[v] Match case
(*) Regular expression
[v] . matches newline
Followed by manual replacements of uses of those type aliases.
github-actions
bot
added
type:Testing
Made it easier to figure out which kind of iterator is being used.
Using Notepad++, Replace in Files, doing:
Find what: ^[ ]+ using (\w+) = (ImageRegionConstIterator<\w+>);\r\n(.*?[^\w])\1
Replace with: $3$2
Filters: itk*.hxx
[v] Match case
(*) Regular expression
[v] . matches newline
Followed by manual replacements of uses of those type aliases.
N-Dekker
force-pushed
the
Remove-local-type-aliases-of-ImageRegionIterator
branch
from
94b5802 to
901ea16
Compare
dzenanz
approved these changes
Mar 25, 2026
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Generally looking good. For this approach (remove definitions then fix if compiler complains) it is important to have non-default modules (review, video, FEM, GPU, etc.) turned on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*.hxxfiles #5839