Merged
Conversation
varonix0
requested review from
ShubhamPalriwala
and removed request for
vmatsiiako
maidul98
previously approved these changes
Jun 10, 2024
Collaborator
maidul98
left a comment
maidul98
left a comment
There was a problem hiding this comment.
looks good to me! Just small nit about changing from site url to host
Contributor
ShubhamPalriwala
left a comment
ShubhamPalriwala
left a comment
There was a problem hiding this comment.
Great work! The docs are clean & work smoothly! Tested all methods except the auths (tried only universal) 🚀 and work as expected ✅
Just added a couple of small notes, please see if they make sense to you as well.
maidul98
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Docs for our new Go SDK.
Type ✨