feat: add limit to the number of retained snapshots and versions#1906
Merged
feat: add limit to the number of retained snapshots and versions#1906
Conversation
sheensantoscapadngan
changed the title
akhilmhdh
requested changes
Jun 4, 2024
Member
akhilmhdh
left a comment
akhilmhdh
left a comment
There was a problem hiding this comment.
Some minor changes need but working as expected on my side.
Good job @sheensantoscapadngan
...ectSettingsPage/components/PointInTimeVersionLimitSection/PointInTimeVersionLimitSection.tsx
Show resolved
Hide resolved
backend/src/ee/services/secret-snapshot/secret-snapshot-service.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
Edge case:
Reason for additional scripts/handling: |
maidul98
approved these changes
Jun 12, 2024
Collaborator
maidul98
left a comment
maidul98
left a comment
There was a problem hiding this comment.
lgtm, just made some small changes
| }, | ||
| onRequest: verifyAuth([AuthMode.JWT]), | ||
| handler: async (req) => { | ||
| const workspace = await server.services.project.updateVersionLimit({ |
Collaborator
There was a problem hiding this comment.
nit: when we make this end point public, we will have to update it to return project and not workspace
Collaborator
|
failing because not rebased, should be solved when merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets