Skip to content

helm daemonset: Allow mounting the host container runtime socket #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
No9 merged 1 commit into from
Jul 22, 2022
Merged

helm daemonset: Allow mounting the host container runtime socket #104

No9 merged 1 commit into from
Jul 22, 2022

Conversation

@psact
Copy link

@psact psact commented Jul 19, 2022

Bottlerocket mounts the containerd socket under /run/dockershim.sock,
which does not appear to be part of the standard privileged container.
Add
mountContainerRuntimeEndpoint: false
hostContainerRuntimeEndpoint: "/run/containerd/containerd.sock"
as chart defaults.

bottlerocket-os/bottlerocket@91810c8
bottlerocket-os/bottlerocket#2212

@No9
Copy link
Collaborator

No9 commented Jul 20, 2022

Sorry I should have reminded you to look at the contributing guide as PRs need a DCO now.
https://github.com/IBM/core-dump-handler/blob/main/CONTRIBUTING.md#developer-certificate-of-origin
Here is a link to a set of options to fix it https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md#how-to-add-sign-offs-retroactively

@psact
helm daemonset: Allow mounting the host container runtime socket
6456a9e 
Bottlerocket mounts the containerd socket under /run/dockershim.sock,
which does not appear to be part of the standard privileged container.
Add
  mountContainerRuntimeEndpoint: false
  hostContainerRuntimeEndpoint: "/run/containerd/containerd.sock"
 as chart defaults.

bottlerocket-os/bottlerocket@91810c8
bottlerocket-os/bottlerocket#2212

Signed-off-by: Peter Scamardo <[email protected]>
@psact psact force-pushed the bottlerocket-dockersock branch from d65d074 to 6456a9e Compare July 20, 2022 22:26
@psact
Copy link
Author

psact commented Jul 20, 2022

Updated commit with DCO

@No9 No9 merged commit 23a23ea into IBM:main Jul 22, 2022
@No9
Copy link
Collaborator

No9 commented Jul 22, 2022 •
edited
Loading

Thanks again for this
I want to document our disclosure policy over the weekend and do a release
I'll set up a prebuild if you want to test it

@psact psact deleted the bottlerocket-dockersock branch July 22, 2022 16:02
@psact
Copy link
Author

psact commented Jul 22, 2022

Sure, let me know where/how I can get it.

@No9
Copy link
Collaborator

No9 commented Aug 7, 2022

Hey @psact
Sorry for the delay - exams and holidays caught up with me.
The pre-release branch is available here https://github.com/IBM/core-dump-handler/tree/pre-8.6.1
It should just be a simple checkout and deploy once the build is done.
https://quay.io/repository/icdh/core-dump-handler/build/c7387a87-262c-4fcd-97c6-84f0fa382300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psact @No9