test-bot: cleanup etc/var after each build.#1100
Merged
Merged
Conversation
zmwangx
approved these changes
Sep 23, 2016
ilovezfs
approved these changes
Sep 23, 2016
Contributor
|
Actually Cellar and stuff need cleanup too. |
ilovezfs
suggested changes
Sep 23, 2016
ilovezfs
left a comment
ilovezfs
left a comment
Contributor
There was a problem hiding this comment.
basically anything covered originally by the git clean needs a new wipe procedure
This has been causing issues when bottling files that are installed to these paths due to the diff algorithm we use for figuring out whether files installed into etc/var belong to a given bottle. Additionally, sometimes not all formulae were uninstalled which meant `brew doctor` would fail.
ilovezfs
approved these changes
Sep 23, 2016
Contributor
|
Travis seems to need its own cure :( #1150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?This has been causing issues when bottling files that are installed to these paths due to the diff algorithm we use for figuring out whether files installed into etc/var belong to a given bottle.