fix: editing table data on mysql versions without generated column support

ansgarbecker · ansgarbecker · commit 22dde7fd7dee · 2026-03-20T09:53:58.000+01:00
Refs #462
diff --git a/source/const.inc b/source/const.inc
@@ -96,7 +96,8 @@ const
   MsgUnhandledNetType: String = 'Unhandled connection type (%d)';
   MsgUnhandledControl: String = 'Unhandled control in %s';
   MsgDisconnect: String = 'Connection to %s closed at %s';
-  TextInvalidColumn: String = '?';
+  // This must be an empty string, otherwise TTableColumn's get GenerationExpression=XYZ on old servers
+  TextInvalidColumn: String = '';
   FILEFILTER_SQLITEDB = '*.sqlite3;*.sqlite;*.db;*.s3db';
   FILEEXT_SQLITEDB = 'sqlite3';
   PROPOSAL_ITEM_HEIGHT = 18;
diff --git a/source/main.pas b/source/main.pas
@@ -11012,7 +11012,7 @@ procedure TMainForm.AnyGridEditing(Sender: TBaseVirtualTree; Node:
         if Assigned(ColInfo) then begin
           Allowed := ColInfo.GenerationExpression.IsEmpty;
           if not Allowed then
-            ErrorDialog(f_('Column %s is defined as generated. You cannot edit its content.', [Column.ToString]));
+            ErrorDialog(f_('Column %s is defined as generated per "%s". You cannot edit its content.', [Column.ToString, ColInfo.GenerationExpression]));
         end;
       end;
 
