fix(src): fix regroup #1148
Merged
fix(src): fix regroup #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Green-Software-Foundation#1108 fixed the issue to prevent duplicate regrouping when the tree has already been regrouped. However, this fix caused only the first subtree to be executed when regrouping needed to be performed on multiple subtrees. Specifically, the execution results of the following manifests became different from before: - manifests/examples/pipelines/scenario-3.yml - manifests/examples/pipelines/pipeline-with-aggregate.yml This PR improves the method for checking if regrouping has been completed and fixes it to correctly detect when regrouping needs to be executed on multiple subtrees. Additionally, it also adds the output results for the above two manifests that were removed in PR Green-Software-Foundation#1037. Signed-off-by: Mitsuru Kariya <[email protected]>
Although not directly related to this fix, the following sample output related to regroup were also removed in PR Green-Software-Foundation#1037, so add it. - manifests/outputs/features/regroup/success.yaml Signed-off-by: Mitsuru Kariya <[email protected]>
jmcook1186
approved these changes
Jun 3, 2025
Contributor
jmcook1186
left a comment
jmcook1186
left a comment
There was a problem hiding this comment.
Thanks for catching this!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request
PR #1108 fixed the issue to prevent duplicate regrouping when the tree has already been regrouped.
However, this fix caused only the first subtree to be executed when regrouping needed to be performed on multiple subtrees. Specifically, the execution results of the following manifests became different from before:
manifests/examples/pipelines/scenario-3.ymlmanifests/examples/pipelines/pipeline-with-aggregate.ymlThis PR improves the method for checking if regrouping has been completed and fixes it to correctly detect when regrouping needs to be executed on multiple subtrees.
Additionally, it also adds the output results for the above two manifests that were removed in PR #1037.
Just in case, I ran
npm run if-check -- -d manifests/outputsand confirmed that there were no changes.