Init codeql-config #1086
Merged
Init codeql-config #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manushak
approved these changes
Dec 3, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| [ifEnvCommand, ifRunCommand, ttyCommand].join(' && ') + | ||
| ` | ${ifDiffCommand}`; | ||
|
|
||
| await execPromise(fullCommand, { |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we should avoid constructing the shell command as a single string and instead use execFileSync or execFile to pass the command and its arguments separately. This approach ensures that the shell does not interpret any special characters in the arguments.
- Replace the construction of
fullCommandwith separate command arrays for each part of the command. - Use
execFileto execute each command separately, passing the arguments as an array to avoid shell interpretation.
Suggested changeset
1
src/if-check/util/npm.ts
| @@ -58,14 +58,19 @@ | ||
|
|
||
| const fullCommand = [ | ||
| ...ifEnvCommand, | ||
| '&&', | ||
| ...ifRunCommand, | ||
| '&&', | ||
| ...ttyCommand, | ||
| '|', | ||
| ...ifDiffCommand, | ||
| ].join(' '); | ||
| // Execute ifEnvCommand | ||
| await execPromise(ifEnvCommand.join(' '), { | ||
| cwd: process.env.CURRENT_DIR || process.cwd(), | ||
| }); | ||
|
|
||
| // Execute ifRunCommand | ||
| await execPromise(ifRunCommand.join(' '), { | ||
| cwd: process.env.CURRENT_DIR || process.cwd(), | ||
| }); | ||
|
|
||
| // Execute ttyCommand | ||
| const ttyResult = await execPromise(ttyCommand.join(' '), { | ||
| cwd: process.env.CURRENT_DIR || process.cwd(), | ||
| }); | ||
|
|
||
| // Execute the full command | ||
| await execPromise(fullCommand, { | ||
| // Execute ifDiffCommand | ||
| await execPromise(ifDiffCommand.join(' '), { | ||
| cwd: process.env.CURRENT_DIR || process.cwd(), |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request