Skip to content

Add multiple edges simultaneously#457

Merged
fsoupimenta merged 4 commits into
mainfrom
453-multiple-edges-simultaneously
Jul 10, 2024
Merged

Add multiple edges simultaneously#457
fsoupimenta merged 4 commits into
mainfrom
453-multiple-edges-simultaneously

Conversation

@fsoupimenta

@fsoupimenta fsoupimenta commented Apr 3, 2024

Copy link
Copy Markdown
Member

Closes #453
Closes #447

@fsoupimenta

fsoupimenta commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

@GraphFilter/version-3-0

The functionality has been implemented and is available for testing by running the application.
However, I believe that the responsibility for this issue belongs to the netgraph library, and not to us. That's why I took the initiative to open an issue in their repository with this request: paulbrodersen/netgraph#88

In addition, during implementation, i identified some bugs that caused the software to fail. To get around these problems, it was necessary to overwrite the netgraph method of adding nodes. This reinforces the idea that it is not our responsibility to implement this functionality.

Note

While we wait for a response from the netgraph, if you want to test the functionality, simply select several vertices at the same time using Ctrl + left mouse click and drag, then press the plus button + or = anywhere on the board.

@atilaajones

atilaajones commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@fsoupimenta
I did the tests.
I observed some unexpected behavior when running the procedure:

  1. Select several vertices using the rectangle with the left mouse button;
  2. Insert new vertex;
  3. The software slowed down a bit and lost the labels of the new vertices

The same behavior occurred when selecting using the CTRL button. Is this the same behavior you got?

Please note that the issue paulbrodersen/netgraph#88 has been answered, so please forward it.

@fsoupimenta fsoupimenta force-pushed the 453-multiple-edges-simultaneously branch from ca41f9a to 9adfc25 Compare July 9, 2024 00:15
@fsoupimenta fsoupimenta marked this pull request as ready for review July 9, 2024 01:01
@fsoupimenta fsoupimenta requested a review from atilaajones July 9, 2024 01:01
@fsoupimenta fsoupimenta self-assigned this Jul 9, 2024
atilaajones
atilaajones requested changes Jul 10, 2024
View reviewed changes

@atilaajones atilaajones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Unexpected behavior when inserting a vertex using the + key.
  • Vertex is not removed using the DEL key

Change the help text (?) of the project window:
Insert or + or =: Insert a new node (this will be adjacent to previously selected vertices)

Insert a new line of help text:
Hold and drag left-click: Select multiple edges and vertices

@fsoupimenta fsoupimenta force-pushed the 453-multiple-edges-simultaneously branch from 5c01f8f to 9622643 Compare July 10, 2024 02:28
@fsoupimenta fsoupimenta requested a review from atilaajones July 10, 2024 02:35
@fsoupimenta fsoupimenta merged commit 7ee52d3 into main Jul 10, 2024
@fsoupimenta fsoupimenta deleted the 453-multiple-edges-simultaneously branch July 10, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LBeghini LBeghini LBeghini approved these changes
@atilaajones atilaajones Awaiting requested review from atilaajones

Assignees

@fsoupimenta fsoupimenta

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple edges simultaneously New vertex adjacent to selected vertices

3 participants

@fsoupimenta @atilaajones @LBeghini