Fix bug on start blank project#371
Merged
atilaajones merged 3 commits intoJun 23, 2023
Merged
Conversation
atilaajones
requested changes
Jun 22, 2023
Contributor
There was a problem hiding this comment.
I found a bug. To reproduce you must open a file, after repeat New > Project > Blank, preferably by switching directories in the new project. There are times when the following happens.
C:\GitHub\GraphFilter\venv\Scripts\python.exe` C:\GitHub\GraphFilter\app.py
C:\GitHub\GraphFilter\venv\Lib\site-packages\netgraph\_utils.py:360: RuntimeWarning: invalid value encountered in divide
v = v / np.linalg.norm(v, axis=-1)[:, None] # unit vector
KeyError: 2
Traceback (most recent call last):
File "C:\GitHub\GraphFilter\venv\Lib\site-packages\matplotlib\cbook\__init__.py", line 307, in process
func(*args, **kwargs)
File "C:\GitHub\GraphFilter\source\view\project\docks\visualize_graph_dock.py", line 153, in _on_motion
self.set_node_positions_store()
File "C:\GitHub\GraphFilter\source\view\project\docks\visualize_graph_dock.py", line 139, in set_node_positions_store
node_positions[self.node_labels[node]] = (x / 1.575, y / 1.75)
~~~~~~~~~~~~~~~~^^^^^^
Process finished with exit code -1073740791 (0xC0000409)
Member
Author
I believe this behavior is because for some reason, the reset of the position dictionary that we have in the store is not working as it should. I have added some additional control points that I believe will prevent this behavior 993f74b |
Contributor
|
The error is still there, but the way of playback has changed:
|
atilaajones
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #370