Skip to content

Update methods with try exception to avoid freezing#357

Merged
atilaajones merged 2 commits into
mainfrom
337-update-methods-with-try-exception-to-avoid-freezing
Jun 15, 2023
Merged

Update methods with try exception to avoid freezing#357
atilaajones merged 2 commits into
mainfrom
337-update-methods-with-try-exception-to-avoid-freezing

Conversation

@fsoupimenta

Copy link
Copy Markdown
Member

Closes #337

@fsoupimenta fsoupimenta added the refactor Code optimization or organization label Jun 15, 2023
@fsoupimenta fsoupimenta self-assigned this Jun 15, 2023
@fsoupimenta fsoupimenta added bug Something isn't working enhancement New feature or request and removed refactor Code optimization or organization labels Jun 15, 2023

@atilaajones atilaajones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to calculate an invariant with an error, the program freezes and the try-except implemented in this branch cannot catch the error coming from a subsequent method. Please review this case in the future.

@atilaajones atilaajones merged commit 489e1c4 into main Jun 15, 2023
@atilaajones atilaajones deleted the 337-update-methods-with-try-exception-to-avoid-freezing branch June 15, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update methods with try-exception to avoid freezing

2 participants