Skip to content

Implement loading window to long operations#350

Merged
fsoupimenta merged 10 commits into
mainfrom
338-implement-loading-window-to-long-operations
Jun 21, 2023
Merged

Implement loading window to long operations#350
fsoupimenta merged 10 commits into
mainfrom
338-implement-loading-window-to-long-operations

Conversation

@rosaigor138

@rosaigor138 rosaigor138 commented Jun 10, 2023

Copy link
Copy Markdown
Member

Closes #338

@rosaigor138 rosaigor138 self-assigned this Jun 10, 2023
@rosaigor138 rosaigor138 added the enhancement New feature or request label Jun 10, 2023
…ph-window

Bug fixes in loading gif window
@rosaigor138 rosaigor138 marked this pull request as ready for review June 15, 2023 00:24
@atilaajones atilaajones marked this pull request as draft June 15, 2023 14:50
@fsoupimenta fsoupimenta marked this pull request as ready for review June 21, 2023 17:19
@fsoupimenta fsoupimenta self-assigned this Jun 21, 2023
@fsoupimenta

Copy link
Copy Markdown
Member

To have it work as desired, I implemented a thread to parallelize the activity of showing the gif and loading the data.

@atilaajones

Copy link
Copy Markdown
Contributor

A bug was observed in the graph plotting. To reproduce:

  1. do some graph toggling in a .g6 list, via combobox.
  2. Open a large file (tests/graphs4.g6)
    Then the loading window (gif) would freeze and the software would crash. Or it would plot incorrectly.

image

@fsoupimenta

Copy link
Copy Markdown
Member

A bug was observed in the graph plotting. To reproduce:

  1. do some graph toggling in a .g6 list, via combobox.
  2. Open a large file (tests/graphs4.g6)
    Then the loading window (gif) would freeze and the software would crash. Or it would plot incorrectly.

image

This bug occurs because in some specific situations the graph does not reset the store position dictionary properly.

Then, a new graph was plotted using the position information from the previous one, which in turn had a different number of nodes and edges.

This bug was fixed in 84e8c61.

Parallel to this, it was observed that the color change in the combo caused the software to lose performance. So the feature was duly removed

@fsoupimenta fsoupimenta merged commit fa46e41 into main Jun 21, 2023
@fsoupimenta fsoupimenta deleted the 338-implement-loading-window-to-long-operations branch June 21, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement loading window to long operations

3 participants