Skip to content

Update to "Find a example"#324

Merged
fsoupimenta merged 18 commits into
mainfrom
313-change-Find-a-counterexample-to-Find-an-example-
Jun 1, 2023
Merged

Update to "Find a example"#324
fsoupimenta merged 18 commits into
mainfrom
313-change-Find-a-counterexample-to-Find-an-example-

Conversation

@atilaajones

@atilaajones atilaajones commented May 25, 2023 •
edited by fsoupimenta
Loading

Copy link
Copy Markdown
Contributor

There are two problems yet:

rosaigor138 and others added 5 commits May 23, 2023 18:45
@rosaigor138
Pdf report WIP
198060e
@rosaigor138
Update pdf_generator.py
ed6e204
@rosaigor138
Generation of pdf and g6 after filtering and example WIP
4ef2651
@rosaigor138
Review_page changes WIP
1c43b76
@atilaajones
Update to "Find a example"
fae33f8 
Update to "Find a example"
Fix problems with find a example and multiprocess.

TODO: When start "Find a example", the loading bar starts infinit loop, at line 30 in filter_controller.py
@atilaajones atilaajones added bug Something isn't working enhancement New feature or request labels May 25, 2023
@atilaajones atilaajones added this to the 3.0.0 milestone May 25, 2023
@atilaajones atilaajones self-assigned this May 25, 2023
@atilaajones

atilaajones commented May 25, 2023

Copy link
Copy Markdown
Contributor Author

The problems cited was solved.

It was noted that it is important to instantiate filter_list at each new filtering. Because the progress bar was inheriting values for different filtering. So Closes #326

@atilaajones

atilaajones commented May 25, 2023

Copy link
Copy Markdown
Contributor Author

There is a bug with Find a example (second time)

File "...\filter_controller.py", line 35, in start_filter
    value = int(((self.filter_list.update_to_progress_bar.value / len(g6_list)) * 100))
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'int' object has no attribute 'value'

@atilaajones

atilaajones commented May 25, 2023

Copy link
Copy Markdown
Contributor Author

There is a bug with Find a example (second time)

File "...\filter_controller.py", line 35, in start_filter
    value = int(((self.filter_list.update_to_progress_bar.value / len(g6_list)) * 100))
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'int' object has no attribute 'value'

Solved with self.update_to_progress_bar.value = self.total, line 124 in filter_list.

@atilaajones
Increase need_mulprocess method
9638a73 
It is necessary that the number of input graphs is greater than the number of cores.
@atilaajones
Fixing minor formatting problems
9a9aba0
@atilaajones atilaajones marked this pull request as ready for review May 25, 2023 22:44
@atilaajones atilaajones changed the title Update to "Find a example" Update to "Find a example" and Report PDF May 31, 2023
@atilaajones

atilaajones commented May 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Closes #314

@atilaajones atilaajones changed the title Update to "Find a example" and Report PDF Update to "Find a example" May 31, 2023
@fsoupimenta

fsoupimenta commented Jun 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@atilaajones You must put the closes command in the PR description, otherwise it doesn't work.
In this case, this PR closes two issues, so it is necessary to put it separately.

@fsoupimenta fsoupimenta merged commit b7a96a5 into main Jun 1, 2023
@fsoupimenta fsoupimenta deleted the 313-change-Find-a-counterexample-to-Find-an-example- branch June 1, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fsoupimenta fsoupimenta fsoupimenta approved these changes
@rosaigor138 rosaigor138 Awaiting requested review from rosaigor138

Assignees

@atilaajones atilaajones

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Loading bar in second filtering Change "Find a counterexample" to "Find an example"

3 participants

@atilaajones @fsoupimenta @rosaigor138