Skip to content

Implement a QMenu to export in another format#322

Merged
fsoupimenta merged 15 commits into
mainfrom
316-implement-a-qmenu-to-export-in-another-format
Jun 1, 2023
Merged

Implement a QMenu to export in another format#322
fsoupimenta merged 15 commits into
mainfrom
316-implement-a-qmenu-to-export-in-another-format

Conversation

@fsoupimenta

@fsoupimenta fsoupimenta commented May 24, 2023

Copy link
Copy Markdown
Member

Closes #316

@fsoupimenta fsoupimenta self-assigned this May 24, 2023
@fsoupimenta fsoupimenta marked this pull request as draft May 24, 2023 00:25
atilaajones
atilaajones requested changes May 25, 2023
View reviewed changes
Comment thread source/store/export_graph_to.py Outdated
Comment thread source/store/export_graph_to.py Outdated
@atilaajones

atilaajones commented May 25, 2023

Copy link
Copy Markdown
Contributor

Insert also the export to .txt (Graph6)

@fsoupimenta fsoupimenta marked this pull request as ready for review May 25, 2023 14:07
@fsoupimenta fsoupimenta requested a review from atilaajones May 25, 2023 14:07
atilaajones
atilaajones requested changes May 25, 2023
View reviewed changes

@atilaajones atilaajones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last review I indicated that we should use new methods for generating PNG and TikZ to make it possible to print the graph with the positions and labels. Since the new functions allow this.

I believe that the export texts below will be clearer to the user

  • Image (.png)
  • Graph6 (.g6)
  • Graph6 (.txt)
  • Graph (.gml)
  • Latex Tikz (.latex)

@fsoupimenta fsoupimenta added the enhancement New feature or request label May 25, 2023
@fsoupimenta

fsoupimenta commented May 28, 2023

Copy link
Copy Markdown
Member Author

In the last review I indicated that we should use new methods for generating PNG and TikZ to make it possible to print the graph with the positions and labels. Since the new functions allow this.

I believe that the export texts below will be clearer to the user

  • Image (.png)
  • Graph6 (.g6)
  • Graph6 (.txt)
  • Graph (.gml)
  • Latex Tikz (.latex)

Done!

@fsoupimenta fsoupimenta requested a review from atilaajones May 28, 2023 15:46
@atilaajones
Reusing library network2tikz
eaf7ba3 
With network2tikz we can plot with labels and positions.
@atilaajones

atilaajones commented Jun 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • I reimplemented with the network2tikz library, because it was more complete. In nx.draw_latex the vertices were being plotted too close together and without labels. The network2tikz meets everything we need.
  • I made vertices at color #EEF25C into PNG format
  • Implemented: Export Graph to PDF
  • Inserted labels in PDF and PNG export all function

@fsoupimenta

fsoupimenta commented Jun 1, 2023

Copy link
Copy Markdown
Member Author
  • I reimplemented with the network2tikz library, because it was more complete. In nx.draw_latex the vertices were being plotted too close together and without labels. The network2tikz meets everything we need.
  • I made the transparent vertices with black border into PNG format

That's fine! Just don't forget to re-add network2tikz to requirements

@fsoupimenta fsoupimenta merged commit 27806aa into main Jun 1, 2023
@fsoupimenta fsoupimenta deleted the 316-implement-a-qmenu-to-export-in-another-format branch June 1, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atilaajones atilaajones atilaajones approved these changes
@rosaigor138 rosaigor138 Awaiting requested review from rosaigor138

Assignees

@fsoupimenta fsoupimenta

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement a QMenu to export in another format

2 participants

@fsoupimenta @atilaajones