Skip to content

Read-write new graph formats AND Refactor Informations Store#319

Merged
atilaajones merged 31 commits into
mainfrom
309-read-and-write-new-graph-formats
May 23, 2023
Merged

Read-write new graph formats AND Refactor Informations Store#319
atilaajones merged 31 commits into
mainfrom
309-read-and-write-new-graph-formats

Conversation

@fsoupimenta

Copy link
Copy Markdown
Member

Closes #309
Closes #307

@fsoupimenta fsoupimenta self-assigned this May 21, 2023

@atilaajones atilaajones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the user move a node and save as .gml file, it is not saving the correct positions.

In the image below guess that the options can be:

- New file (.gml)
- Insert in final of the current list (g6 file only)

image

Comment thread source/domain/utils_file.py
Comment thread source/controller/project_controller.py Outdated
@atilaajones atilaajones changed the title Read and write new graph formats Read-write new graph formats and Refactor Informations Store May 21, 2023
@atilaajones atilaajones changed the title Read-write new graph formats and Refactor Informations Store Read-write new graph formats AND Refactor Informations Store May 21, 2023
@fsoupimenta

Copy link
Copy Markdown
Member Author

When the user move a node and save as .gml file, it is not saving the correct positions.

In the image below guess that the options can be:

- New file (.gml)
- Insert in final of the current list (g6 file only)

image

Done!

@fsoupimenta fsoupimenta requested a review from atilaajones May 23, 2023 10:29

@atilaajones atilaajones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When opening an invalid graph (any format) insert in the alert message, with parentheses and brake-line: "(If you edit the graph, the changes will replace the invalid graph)".

Rename the test .gml file to GraphGML.gml

@fsoupimenta

Copy link
Copy Markdown
Member Author

GraphGML

Done!

@fsoupimenta fsoupimenta requested a review from atilaajones May 23, 2023 19:36
@atilaajones atilaajones merged commit d74c244 into main May 23, 2023
@atilaajones atilaajones deleted the 309-read-and-write-new-graph-formats branch May 23, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read and write new graph formats Refactor Project Information Store

3 participants