Layout to new graph#299
Merged
Merged
Conversation
Set layout circular on Complete, Path, Cycle and Turan graphs
atilaajones
requested changes
May 9, 2023
atilaajones
left a comment
atilaajones
left a comment
Contributor
There was a problem hiding this comment.
Plotting is not working. I tried to plot the cycle graph, grid graph or another, but the plotting continues as spring. I don't think it is necessary to assign layout='spring' in MplCanvas, since this already happens in other calls.
Sometimes the program crashes when we try to create new graphs.
atilaajones
requested changes
May 9, 2023
Contributor
There was a problem hiding this comment.
The Triangular Lattice Graph is ploted out of screen, when m=5 and n=10.
In addition, I observed that I need to get some conditions right.
- Cograph: typo "<"
- Grid and Triangular: You have to check if the product mxn is less than 60, not each of them separately.
atilaajones
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #296