Skip to content

docs(compute-samples): added windows samples and tests#7141

Merged
Sita04 merged 2 commits into
mainfrom
windows-samples
May 14, 2022
Merged

docs(compute-samples): added windows samples and tests#7141
Sita04 merged 2 commits into
mainfrom
windows-samples

Conversation

@Sita04

@Sita04 Sita04 commented May 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

for 1. Creating and managing instances
2. OS image

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@Sita04
docs(compute-samples): added windows samples and tests
415f3a4 
for 1. Creating and managing instances
2. OS image
@Sita04 Sita04 requested review from a team and yoshi-approver as code owners May 13, 2022 07:26
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label May 13, 2022
@snippet-bot

snippet-bot Bot commented May 13, 2022 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Sita04 Sita04 merged commit eaa33a5 into main May 14, 2022
@Sita04 Sita04 deleted the windows-samples branch May 14, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner
1 more reviewer
@eaball35 eaball35 eaball35 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sita04 @eaball35 @averikitsch