encode space to conform new gfm specs#32
Merged
Froussios merged 1 commit intoFroussios:masterfrom Mar 31, 2017
aldoKelvianto:bugfix/encode-space
Merged
encode space to conform new gfm specs#32Froussios merged 1 commit intoFroussios:masterfrom aldoKelvianto:bugfix/encode-space
Froussios merged 1 commit intoFroussios:masterfrom
aldoKelvianto:bugfix/encode-space
Conversation
Owner
|
I must have missed the announcement. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new GitHub Flavored Markdown specs require dynamic link with no spaces. So, we have to use static link or encode the spaces. If we're still using spaces, the link won't shown (and it looks kinda weird
)